feat(http.cr): default to HTTPS #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably shouldn't be doing anything over HTTP anyway, so I would not consider this a breaking change. With HTTP I was getting this error and it seems onerous to have to specify a `@custom_endpoint` for HTTPS `Requests specifying Server Side Encryption with AWS KMS managed keys must be made over a secure connection`
fixes compatibility with crystal 0.33
there is no queuing in the crystal HTTP library so if two requests occur on different fibers they both write to the same IO This typically causes requests to fail as the S3 hash check fails
|
@taylorfinnell fixed up the spec and a couple of other issues i ran into when using this in production. |
|
Hey, thanks! Happy to merge this, looks like some tests are still failing and I think it needs a |
|
Sweet, that was probably it. |
|
Ahh now it's a crystal 0.34 error. |
couldn't make crystal tool format find any issues on linux or macos - so not sure what travis is complaining about.
|
@taylorfinnell I literally cannot replicate the issue with |
|
Yea, I can't repro it locally either, very weird. I will go ahead and merge this. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably shouldn't be doing anything over HTTP anyway, so I would not consider this a breaking change.
With HTTP I was getting this error and it seems onerous to have to specify a
@custom_endpointfor HTTPSRequests specifying Server Side Encryption with AWS KMS managed keys must be made over a secure connection