tbsecp3: fix compiler warnings #299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings From -Wtautological-compare in GCC. Masking a value and comparing to one will only work if the mask itself is equal to one (which is not the case here). Comparing to zero works for any mask.
From -Wmisleading-indentation in GCC.
drivers/media/pci/tbsecp3/tbsecp3-dvb.c: In function ‘tbsecp3_frontend_attach’:
drivers/media/pci/tbsecp3/tbsecp3-dvb.c:1487:17: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
1487 | if (adapter->fe == NULL)
| ^~
drivers/media/pci/tbsecp3/tbsecp3-dvb.c:1489:21: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
1489 | if(adapter->nr <4)
| ^~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bitwise comparisons checking for mcu busy on bit 2 always evaluated false.
The tbsecp3 directory now only warns for one unused variable and two unused functions in tbsecp3-dbc.c which left for now.