write data up until error in setFromX methods #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This got consensus; landing, but I do still need to update test262 tests. |
|
Heads up that this PR says the AO returns a record whose [[Error]] is a throw completion, but in this case it's actually an Error instance. |
ljharb
added a commit
to es-shims/es-arraybuffer-base64
that referenced
this pull request
Jul 8, 2024
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jul 13, 2024
…pe.setFrom{Base64,Hex} methods. r=spidermonkey-reviewers,dminor
Change `FromHex` and `FromBase64` to accept a templated `Sink` parameter, which
either appends to a `ByteVector` or directly into the target `TypedArrayObject`.
`Uint8Array.prototype.setFrom{Base64,Hex}` now no longer have to allocate
temporary space when processing the input string.
Changes from:
tc39/proposal-arraybuffer-base64#58
Depends on D216279
Differential Revision: https://phabricator.services.mozilla.com/D216280
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 13, 2024
…pe.setFrom{Base64,Hex} methods. r=spidermonkey-reviewers,dminor
Change `FromHex` and `FromBase64` to accept a templated `Sink` parameter, which
either appends to a `ByteVector` or directly into the target `TypedArrayObject`.
`Uint8Array.prototype.setFrom{Base64,Hex}` now no longer have to allocate
temporary space when processing the input string.
Changes from:
tc39/proposal-arraybuffer-base64#58
Depends on D216279
Differential Revision: https://phabricator.services.mozilla.com/D216280
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 15, 2024
…pe.setFrom{Base64,Hex} methods. r=spidermonkey-reviewers,dminor
Change `FromHex` and `FromBase64` to accept a templated `Sink` parameter, which
either appends to a `ByteVector` or directly into the target `TypedArrayObject`.
`Uint8Array.prototype.setFrom{Base64,Hex}` now no longer have to allocate
temporary space when processing the input string.
Changes from:
tc39/proposal-arraybuffer-base64#58
Depends on D216279
Differential Revision: https://phabricator.services.mozilla.com/D216280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #57.
One difficulty is that in the case of an error there's no good way to know how many bytes were read/written. I don't think that's a problem we need to solve; in practice you are unlikely to have any way to recover in the case of an error, so you're just going to throw the buffer away.
(It would be nice for SyntaxErrors to have a standardized
.offsetproperty which told you where the error was, not just for this but alsoJSON.parseetc. But that's unlikely to be in this proposal.)