Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for TLA DFS invariant #2989

Merged
merged 1 commit into from
May 14, 2021
Merged

Conversation

jugglinmike
Copy link
Contributor

This behavior was introduced after the Top-Level Await proposal reached
stage 3: tc39/proposal-top-level-await#159

This behavior was introduced after the Top-Level Await proposal reached
stage 3: tc39/proposal-top-level-await#159
@jugglinmike
Copy link
Contributor Author

@MylesBorins @codehag @guybedford Would you mind taking a look at this?

dfs-invariant-direct-1_FIXTURE.js dfs-invariant-direct-2_FIXTURE.js
'--------. .--------'
v v
dfs-invariant-async_FIXTURE.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love when you make these <3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

                ,------------------. ->  @rwaldron  --.
@jugglinmike -> | dfs-invariant.js |                  +-> Test262
                '------------------' -> @guybedford --'

Copy link

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this captures the case, even though it's a slightly different example.

@jugglinmike
Copy link
Contributor Author

Thanks, Guy! Thanks, Rick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants