Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I interpret following code (the files named in "exclude_name_pattern") that you want to not include password information from the local system in the collected dataset:
uac/artifacts/files/system/etc.yaml
Lines 4 to 9 in ff47553
This does not work for BSD-based operating systems (OpenBSD, FreeBSD, NetBSD, etc.). For those OSs, the files
/etc/master.passwd
and/etc/spwd.db
contain the hashed passwords of local users. I added the two files to the code.I executed UAC with the changes on an OpenBSD machine and the two files in question were excluded. I did not check for any side-effect with the other artifacts.