Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude BSD password files #175

Merged
merged 1 commit into from
Oct 5, 2023
Merged

exclude BSD password files #175

merged 1 commit into from
Oct 5, 2023

Conversation

Herbert-Karl
Copy link
Contributor

@Herbert-Karl Herbert-Karl commented Oct 1, 2023

Hi,

I interpret following code (the files named in "exclude_name_pattern") that you want to not include password information from the local system in the collected dataset:

description: Collect system configuration files.
supported_os: [aix, android, esxi, freebsd, linux, netbsd, netscaler, openbsd, solaris]
collector: file
path: /etc
exclude_name_pattern: ["shadow", "shadow-"]
ignore_date_range: true

This does not work for BSD-based operating systems (OpenBSD, FreeBSD, NetBSD, etc.). For those OSs, the files /etc/master.passwd and /etc/spwd.db contain the hashed passwords of local users. I added the two files to the code.

I executed UAC with the changes on an OpenBSD machine and the two files in question were excluded. I did not check for any side-effect with the other artifacts.

@tclahr
Copy link
Owner

tclahr commented Oct 2, 2023

That's awesome! Great contribution.
Can you re-submit it but selecting 'develop' as the merging branch, please?
Thanks!

@Herbert-Karl Herbert-Karl changed the base branch from main to develop October 3, 2023 13:15
@Herbert-Karl
Copy link
Contributor Author

merging branch changed

Copy link
Owner

@tclahr tclahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition. Thanks!

@tclahr tclahr merged commit 8cd0aca into tclahr:develop Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants