move tool logs to the front of archive #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create pisi.yaml
Revert "Create pisi.yaml"
This moves the tool's logs to the front of the tar archive rather than the tail. As tar is a stream format, having them at the tail ends up requiring that automation read the archive twice: once to gather details crucial to routing and parsing the data it contains, and once to actually parse the data. Most solutions will likely still want to read archives twice in order to handle ones generated before this change, but at least they can terminate the first pass when they finish parsing the log file, thus minimizing waste.
|
This addresses bug #216 |
tclahr
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the tool's logs to the front of the tar archive rather than the tail. As tar is a stream format, having them at the tail ends up requiring that automation read the archive twice: once to gather details crucial to routing and parsing the data it contains, and once to actually parse the data.
Most solutions will likely still want to read archives twice in order to handle ones generated before this change, but at least they can terminate the first pass when they finish parsing the log file, thus minimizing waste.