Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forbidEndingPeriod #196

Closed
piranna opened this issue Jan 14, 2020 · 4 comments · Fixed by #207
Closed

forbidEndingPeriod #196

piranna opened this issue Jan 14, 2020 · 4 comments · Fixed by #207
Labels
enhancement 👑 New feature or request
Milestone
v4.6.0

Comments

@piranna
Copy link

piranna commented Jan 14, 2020

npm-package-json-lint/src/rules/description-format.js

Line 33 in b323308

if (config.hasOwnProperty('requireEndingPeriod') && config.requireEndingPeriod && !description.endsWith('.')) {

The same that there's a requireEndingPeriod option, add a new one for forbidEndingPeriod, or allow it to be three state.
@tclindner
Copy link
Owner

I like it! Thanks for the suggestion. I’ll take a stab when I review the other ticket you commented on.

@piranna
Copy link
Author

piranna commented Jan 15, 2020

Nice! :-D

@tclindner tclindner added the enhancement 👑 New feature or request label Jan 30, 2020
@tclindner tclindner added this to the v4.6.0 milestone Jan 30, 2020
tclindner added a commit that referenced this issue Feb 3, 2020
@tclindner
Add forbidEndingPeriod
bebdc75 
Closes #196
@tclindner tclindner mentioned this issue Feb 3, 2020
Merged
2 tasks
tclindner added a commit that referenced this issue Feb 3, 2020
@tclindner
4.6.0 (#207)
972f673 
* Bump version

* Add forbidEndingPeriod

Closes #196

* Add docs for forbidEndingPeriod
@tclindner
Copy link
Owner

v4.6.0 has been released with the new option. I'll consolidate them in v5.0.0 (breaking change).

@piranna
Copy link
Author

piranna commented Feb 3, 2020

Cool, thanks! :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 👑 New feature or request
Projects
None yet
Milestone
v4.6.0
Development

Successfully merging a pull request may close this issue.

4.6.0 tclindner/npm-package-json-lint
2 participants
@piranna @tclindner