Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export write method #875

Merged
merged 3 commits into from
Nov 25, 2022
Merged

feat: export write method #875

merged 3 commits into from
Nov 25, 2022

Conversation

dangreen
Copy link
Contributor

Description of change

I need the write method to implement a custom executable script.

Checklist

  • Unit tests have been added
  • Specific notes for documentation, if applicable

@dangreen dangreen marked this pull request as ready for review November 20, 2022 11:20
@dangreen
Copy link
Contributor Author

@tclindner Hi. Review pls 🙏

@dangreen
Copy link
Contributor Author

@tclindner ping

@tclindner tclindner added the enhancement 👑 New feature or request label Nov 24, 2022
@tclindner
Copy link
Owner

Thank you! Would you mind adding a quick test for coverage.

@dangreen
Copy link
Contributor Author

@tclindner Done

@tclindner tclindner enabled auto-merge (squash) November 25, 2022 21:19
@tclindner tclindner merged commit f183e59 into tclindner:master Nov 25, 2022
@tclindner
Copy link
Owner

Released!

@dangreen dangreen deleted the feat-export-write branch November 26, 2022 16:04
@dangreen
Copy link
Contributor Author

@tclindner Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclindner tclindner tclindner approved these changes

Assignees
No one assigned
Labels
enhancement 👑 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dangreen @tclindner