This repository has been archived by the owner on Mar 17, 2023. It is now read-only.
Disable option (alternative to bypassOnDebug) #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
disableoption (updated readme as well)Why? Basically just alternative to bypassOnDebug, because that option depends on webpack debug mode, which was deprecated in version 2 (https://stackoverflow.com/a/41779342). The new
disableoption doesn't. Thedisableoption also seems to be the common way for other webpack loaders and plugins.Replaced
rm -rfwith rimrafWhy? Because rimraf is compatible with Windows, while
rm -rfis not (at least not by default), this also caused test script to fail, but not with rimraf.Added package-lock.json
Why? It's automatically added by npm, from version 5 I think.
Updated imagemin dependencies
Why? Why not?