[UI/#19] Onboarding / 학교 뷰, 학과/학번 선택 뷰 #23

minju1459 · 2023-07-08T19:51:31Z

closed [UI] OnBoarding / 학교 선택 뷰, 학과 학번 선택 뷰 #19

⛳️ Work Description

학교 선택 뷰 UI
학과/학번 선택 뷰 UI

📸 Screenshot

device-2023-07-09-044540.webm

📢 To Reviewers

학번 선택 bottomsheetdialog 부분은 BottomSheetAdapter를 구현하며 처리할 예정입니다.
빠진 부분이 있을 수 있어 디테일한 UI 검토는 서버 통신 끝나마자 들어가겠습니다 !!

Marchbreeze

고생티비~~~~~

Marchbreeze · 2023-07-09T05:58:47Z

.../com/yello/presentation/onboarding/fragment/StudentID/list/SearchDialogDepartmentFragment.kt

+import com.yello.databinding.FragmentDialogDepartmentBinding
+
+class SearchDialogDepartmentFragment :
+    BindingBottomSheetDialog<FragmentDialogDepartmentBinding>(R.layout.fragment_dialog_department) {


오호 바텀시트도 BindingDialog가 있네요 ! 프로필 뷰에서 활용하겠습니다 ㅎㅎ

좋아요오~~~~!!

Marchbreeze · 2023-07-09T05:59:34Z

.../com/yello/presentation/onboarding/fragment/StudentID/list/SearchDialogDepartmentFragment.kt

+    companion object {
+        @JvmStatic
+        fun newInstance() = SearchDialogDepartmentFragment()
+    }


@JvmStatic 활용법 공부해보고 활용할 수 있으면 좋을듯 ! 공부하면 알려줘용

@minju1459 @Marchbreeze 자바에서는 static을 사용해서 정적으로 메소드를 만들 수 있는데
코틀린에서는 static이란 메소드가 없어서 companion object를 사용해서 안에 함수를 사용하게 되는데
사실상 companion object안에 함수들은 static이 아닌 object 자체가 static이라서
함수 자체를 static처럼 사용하고 싶을 때는 @JvmStatic을 붙여주면 됩니다.

Marchbreeze · 2023-07-09T06:01:51Z

app/src/main/java/com/yello/presentation/onboarding/fragment/school/SchoolAdpapter.kt

+            onItemsTheSame = { old, new -> old.schoolname == new.schoolname },
+            onContentsTheSame = { old, new -> old == new },
+        )
+    }


diffutil 따로 빼두니깐 훨씬 더 깔끔하네요 ~~

Marchbreeze · 2023-07-09T06:06:12Z

app/src/main/res/layout/item_school_list.xml

+            android:layout_width="0dp"
+            android:layout_height="wrap_content"
+            android:layout_marginStart="8dp"
+            android:text="@{data.schoolname}"


활용 좋아요 ~~~~~

Marchbreeze · 2023-07-09T06:11:44Z

app/src/main/res/layout/fragment_dialog_department.xml

+            android:textSize="16sp"
+            app:layout_constraintEnd_toEndOf="parent"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintTop_toTopOf="parent" />


이거 textAppearence로 사전 설정되어 있는 속성으로 글꼴, 크기 등등 한번에 지정해주시는게 좋아요 ~~
android:textAppearance="?attr/textAppearanceHeadline3"
이렇게요 !

감사합니당!! 빠르게 수정하도록 하겠습니다 !!

b1urrrr

온보딩 구현하시느라 고생하셨습니다!!

b1urrrr · 2023-07-09T16:24:01Z

app/src/main/java/com/yello/presentation/onboarding/fragment/StudentID/StudentIdFragment.kt

+        initSearchDeaprtmentBtnClickListener()
+    }
+
+    private fun initSearchIDBtnClickListener() {


Suggested change

private fun initSearchIDBtnClickListener() {

private fun initSearchIdBtnClickListener() {

Fragment 형식이랑 통일하는 건 어떤가요?

b1urrrr · 2023-07-09T16:26:02Z

app/src/main/res/layout/fragment_dialog_school.xml

+            android:layout_marginStart="16dp"
+            android:layout_marginTop="12dp"
+            android:layout_marginEnd="16dp"


Suggested change

android:layout_marginStart="16dp"

android:layout_marginTop="12dp"

android:layout_marginEnd="16dp"

android:layout_marginHorizontal="16dp"

android:layout_marginTop="12dp"

이렇게 작성할 수도 있어요!

b1urrrr · 2023-07-09T19:01:57Z

app/src/main/java/com/yello/presentation/onboarding/fragment/StudentID/StudentIdFragment.kt

+    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
+        super.onViewCreated(view, savedInstanceState)
+        initSearchIDBtnClickListener()
+        initSearchDeaprtmentBtnClickListener()


오타 발견ㅋㅋ
참고로 맥북 기준 ⇧F6으로 한번에 네이밍을 수정할 수 있습니다!

b1urrrr · 2023-07-09T19:06:56Z

app/src/main/java/com/yello/presentation/onboarding/fragment/school/SchoolAdpapter.kt

+
+class SchoolAdpapter : ListAdapter<MySchool, SchoolAdpapter.SchoolViewHolder>(diffUtil) {
+    override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): SchoolViewHolder {
+        Timber.d("onCreateViewHolder")


테스트 완료하셨다면 불필요한 Timber도 제거하는 것이 가독성에 좋을 것 같아요!

b1urrrr · 2023-07-09T19:26:22Z

app/src/main/java/com/yello/presentation/onboarding/fragment/school/SchoolAdpapter.kt

+        fun setlist(list: MySchool) {
+            Timber.d("set list : $list")
+            binding.data = list


Suggested change

fun setlist(list: MySchool) {

Timber.d("set list : $list")

binding.data = list

fun setlist(school: MySchool) {

binding.data = school

학교 하나에 대한 변수가 인자로 전달되는데 list라는 네이밍은 조금 부적합한 것 같습니다!

b1urrrr · 2023-07-09T19:31:33Z

app/src/main/res/layout/fragment_dialog_department.xml

+            android:layout_width="24dp"
+            android:layout_height="24dp"


높이나 너비에 고정 dp값을 지정하는 것은 지양해주세요!
다른 컴포넌트들도 한번씩 확인 부탁드립니다!

b1urrrr · 2023-07-09T19:36:22Z

app/src/main/res/layout/fragment_dialog_school.xml

+        android:id="@+id/layout_school_dialog"
+        android:layout_width="match_parent"
+        android:layout_height="match_parent">
+
+        <TextView
+            android:id="@+id/tv_dialog_school"


where에 대한 단어가 컴포넌트마다 다른 것 같은데 통일시켜주는 것이 좋을 것 같습니다!

b1urrrr · 2023-07-09T19:43:35Z

app/src/main/res/layout/fragment_school.xml

+            android:layout_marginStart="16dp"
+            android:layout_marginTop="26dp"
+            android:layout_marginEnd="182dp"


큰 값을 margin이나 padding으로 지정하게 되면 화면 호환성에 문제가 생길 수 있습니다! 요 컴포넌트에서는 marginEnd를 지정하지 않는 것이 적합해보입니당

b1urrrr

뷰 진짜 잘 짰어요 너무 고생하셨습니다🥺
LGTM!!!!!!!!!

minju1459 · 2023-07-10T08:34:47Z

뷰 진짜 잘 짰어요 너무 고생하셨습니다🥺
LGTM!!!!!!!!!

리드님 최고......💛💛

minju1459 added 13 commits July 7, 2023 03:56

[FEAT/#19] bottom dialog 구현

b66d18f

[FEAT/#19] 학과 학번 bottom dialog 구현

dd4db62

[MOD/#cd ..] school view UI

3c743da

[FIX/#19] 버튼 색 적용 이슈 해결

9ee1e6b

[FEAT/#19] 학교 검색 bottomsheet adapter 구현중

63d55cf

[FEAT/#19] 학과, 학번 선택 UI 구현

8d1ede8

[MOD/#19] 학과, xml 컨벤션 정리 및 string.xml에 Tag 적용

ca45507

[MOD/#19] 대표 fragment 키보드 막기

302f014

[ADD/#19] pretendard 글꼴 적용

0e2d990

[FIX/#19] git conflict solve

5e6d90b

[MOD/#19] onboarding package 정리

3e7f7fa

[MOD/#19] background 다시 지정

41cc8f5

[FIX/#19] string git conflict 해결

323943f

minju1459 requested a review from a team as a code owner July 8, 2023 19:51

minju1459 self-assigned this Jul 8, 2023

minju1459 added PULL REQUEST 🚀 pull reqeust 날리기 UI 💐 UI 작업 민주 🌳 Minju's Task labels Jul 8, 2023

minju1459 added this to the UI 구현 milestone Jul 8, 2023

Marchbreeze approved these changes Jul 9, 2023

View reviewed changes

b1urrrr requested changes Jul 9, 2023

View reviewed changes

minju1459 added 8 commits July 10, 2023 13:13

[FIX/#19] 코드 리뷰 반영

c7bec7b

[FIX/#19] 코드 리뷰 반영2

7ef22b8

[FIX/#19] searchdialogfragment 수정

47edb29

[FIX/#19] layout 수정

efda8ee

[FIX/#19] layout 수정

4fd1317

[FIX/#19] layout 수정

557b629

[FIX/#19] layout 수정..끝...

9e4229a

[FIX/#19] layout 수정..끝......

9c9fd64

b1urrrr approved these changes Jul 10, 2023

View reviewed changes

minju1459 merged commit 5340649 into develop Jul 10, 2023
1 check passed

b1urrrr deleted the origin/#19-onboarding-school_studentid branch July 18, 2023 04:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UI/#19] Onboarding / 학교 뷰, 학과/학번 선택 뷰 #23

[UI/#19] Onboarding / 학교 뷰, 학과/학번 선택 뷰 #23

minju1459 commented Jul 8, 2023

Marchbreeze left a comment

Marchbreeze Jul 9, 2023

minju1459 Jul 9, 2023

Marchbreeze Jul 9, 2023

kkk5474096 Jul 10, 2023 •

edited

Loading

Marchbreeze Jul 9, 2023

Marchbreeze Jul 9, 2023

Marchbreeze Jul 9, 2023

minju1459 Jul 9, 2023

b1urrrr left a comment

b1urrrr Jul 9, 2023

b1urrrr Jul 9, 2023

b1urrrr Jul 9, 2023

b1urrrr Jul 9, 2023

b1urrrr Jul 9, 2023

b1urrrr Jul 9, 2023

b1urrrr Jul 9, 2023

b1urrrr Jul 9, 2023

b1urrrr left a comment

minju1459 commented Jul 10, 2023

	private fun initSearchIDBtnClickListener() {
	private fun initSearchIdBtnClickListener() {

[UI/#19] Onboarding / 학교 뷰, 학과/학번 선택 뷰 #23

[UI/#19] Onboarding / 학교 뷰, 학과/학번 선택 뷰 #23

Conversation

minju1459 commented Jul 8, 2023

⛳️ Work Description

📸 Screenshot

📢 To Reviewers

Marchbreeze left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kkk5474096 Jul 10, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

b1urrrr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

b1urrrr left a comment

Choose a reason for hiding this comment

minju1459 commented Jul 10, 2023

kkk5474096 Jul 10, 2023 •

edited

Loading