Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT/#38] OnBoarding / 온보딩 서버통신 연결 #48

Merged
merged 65 commits into from
Jul 19, 2023
Merged

[FEAT/#38] OnBoarding / 온보딩 서버통신 연결 #48

merged 65 commits into from
Jul 19, 2023

Conversation

b1urrrr
Copy link
Member

@b1urrrr b1urrrr commented Jul 19, 2023 •
edited
Loading

⛳️ Work Description

📸 Screenshot

Android.Emulator.-.Galaxy_S21_API_31_5554.2023-07-19.20-52-03.mp4

📢 To Reviewers

  • 스플래시 보완 필요 상태입니둥

minju1459 and others added 30 commits July 16, 2023 21:41
@minju1459
[FIX/#24] viewmodel camel case
46fd551
@minju1459
[FIX/#24] bottomsheet design
5c990a0
@minju1459
[MOD/#24] gender btn
74b3f9a
@minju1459
Merge branch 'develop' of https://github.com/team-yello/YELLO-Android …
604461d 
…into origin/#38-onboarding-api
@minju1459
[FEAT/#38] 학교 찾기 domain,data layer
71be972
@minju1459
[FEAT/#38] 학교 찾기 API 구현
665060d
@minju1459
[FEAT/#38] 학과 찾기 domain, data layer
4f96272
@minju1459
[FEAT/#38] 학과 찾기 API 구현
5190e9d
@minju1459
[FEAT/#38] 아이디 중복 entity
e417974
@minju1459
[FEAT/#38] 아이디 중복, 가입한 친구 목록 api 구현중
3a189e4
@minju1459
[FEAT/#38] git conflict
0f7a186
@minju1459
[FIX/#38] data null fix
db5a8e7
@b1urrrr
[FIX/#38] 온보딩 data null 처리 및 reformat code
fa164a8
@minju1459
[FIX/#38] ㅎgit resolve
07aca9c
@b1urrrr
[ADD/#47] signup dto 데이터 클래스 추가
1fa43ca
@b1urrrr
[MERGE] : develop -> #47
0600d14
@b1urrrr
[FIX/#47] 온보딩 네이밍 컨벤션 적용
b793794
@minju1459
[FIX/#38] 온보딩 네이밍 정정 및 아이디 중복, 친구 불러오기 API 세팅
0b80d60
@minju1459
[FIX/#38] git conflict resolve
7674803
@b1urrrr
[ADD/#47] MainActivity Manifest에 추가
fbf9410
@b1urrrr
Merge branch 'origin/#38-onboarding-api' of https://github.com/team-y…
ba4b14d 
…ello/YELLO-Android into feat/#47-signup-api
@b1urrrr
[FIX/#47] 타이머 남은 시간 범위 미해당 시 Start 상태로 전환
925349d
@b1urrrr
[CHORE/#47] OnBoardingViewModel 코드 정리
c5d1098
@minju1459
[FIX/#38] onboardingviewmodel 주석 제거
9f65500
@b1urrrr
[FIX/#47] 남은 시간 계산 및 타이머 재생 로직 보완
59801d0
@b1urrrr
[FIX/#47] 온보딩 함수명 regex 오타 정정
f079169
@minju1459
[FIX/#38] onboardingRepositorylmpl 수정
5454a3f
@minju1459
[FIX/#38] git conflict
f09add2
@minju1459
[ADD/#38] 친구목록 불러오기 API presentationlayer 구현중..
0c4b79a
@b1urrrr
[FIX/#47] get school list api 로직 수정
190b1d2
b1urrrr and others added 19 commits July 19, 2023 09:25
@b1urrrr
[FIX/#47] 온보딩 프래그먼트 순서 정렬 및 불필요한 띄어쓰기 제거
ed63210
@b1urrrr
[UI/#38] student id 프래그먼트 레이아웃 보완
17d4681
@b1urrrr
[FEAT/#38] 이름 및 옐로 아이디 검증 로직 구현
23663ff
@minju1459
[ADD/#38] splashscreen 의존성 추가
a98e4ac
@b1urrrr
[FEAT/#38] 이름 및 아이디 유효성 검사 UI 구현
c15e533
@minju1459
Merge branch 'origin/#38-onboarding-api' of https://github.com/team-y…
46d9136 
…ello/YELLO-Android into origin/#38-onboarding-api
@minju1459
[ADD/#38] splash lottie 추가
796aff6
@b1urrrr
[FIX/#38] 온보딩 레이아웃 전반적 보완
8bbfd51
@b1urrrr
Merge branch 'origin/#38-onboarding-api' of https://github.com/team-y…
97ff3b0 
…ello/YELLO-Android into origin/#38-onboarding-api
@minju1459
[FIX/#38] splash valus/xml 수정
537a58c
@minju1459
Merge branch 'origin/#38-onboarding-api' of https://github.com/team-y…
70790d9 
…ello/YELLO-Android into origin/#38-onboarding-api
@minju1459
[FIX/#38] splashActivity layout 수정
64e19e3
@minju1459
[FIX/#38] lottie loop 제거
4e3a773
@minju1459
[FIX/#38] yello splash layout 수정
92c4abc
@minju1459
[FEAT/#38] splashActivity 구현
4c884d7
@b1urrrr
[UI/#38] 성별 선택 뷰 구현
cb8efbc
@b1urrrr
[FEAT/#38] 옐로 아이디 중복 처리 API 연결
a57827b
@minju1459
[FEAT/#38] Splash layout 수정중
2079bdd
@minju1459
Merge branch 'origin/#38-onboarding-api' of https://github.com/team-y…
c9c11d7 
…ello/YELLO-Android into origin/#38-onboarding-api
@b1urrrr b1urrrr added FEAT ✨ 새로운 기능 구현 채연 🐸 Chaeyeon's Task 민주 🌳 Minju's Task labels Jul 19, 2023
@b1urrrr b1urrrr added this to the 서버 연결 milestone Jul 19, 2023
@b1urrrr b1urrrr self-assigned this Jul 19, 2023
@b1urrrr b1urrrr requested a review from a team as a code owner July 19, 2023 11:53
minju1459
minju1459 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@minju1459 minju1459 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 너무 수고하셨습니다 !! 리드님 LGTM💛

kkk5474096
kkk5474096 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@kkk5474096 kkk5474096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L~~~GTM

@b1urrrr b1urrrr merged commit a832259 into develop Jul 19, 2023
1 check passed
@minju1459 minju1459 added the PULL REQUEST 🚀 pull reqeust 날리기 label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkk5474096 kkk5474096 kkk5474096 approved these changes

@minju1459 minju1459 minju1459 approved these changes

Assignees

@b1urrrr b1urrrr

@minju1459 minju1459

Labels
FEAT ✨ 새로운 기능 구현 PULL REQUEST 🚀 pull reqeust 날리기 민주 🌳 Minju's Task 채연 🐸 Chaeyeon's Task
Projects
YELL:O ANDROID
Status: Done
Milestone
서버 연결
Development

Successfully merging this pull request may close these issues.

[FEAT] OnBoarding / 서버 통신 구현
3 participants
@b1urrrr @kkk5474096 @minju1459