-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fix deprecated apis 1.16 #110
Merged
Cryptophobia
merged 9 commits into
teamhephy:master
from
Cryptophobia:feature/fix-deprecated-apis-1.16
Oct 1, 2020
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
93682c6
ref(apis): deprecated apis in k8s 1.16
Cryptophobia b4928ed
ref(apis): trying to fix mock tests now
Cryptophobia 27b8f8a
ref(charts): move from extensions/v1beta1 to apps/v1
Cryptophobia a6fa780
ref(mock.py): sanitize pod urls to api_v1 in the mocker
Cryptophobia d8e65a9
ref(apis): parse version out for replicasets
Cryptophobia 25a7f41
ref(mock.py): reduce line length for style check
Cryptophobia fd3feba
docs(README): add travis build status badge
Cryptophobia 5930851
ref(charts): add apiversion checks to helm charts
Cryptophobia 5613bc8
fix(README): resolving a merge conflict
Cryptophobia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,6 @@ | ||
name: controller | ||
home: https://github.com/deisthree/controller | ||
home: https://github.com/teamhephy/controller | ||
version: <Will be populated by the ci before publishing the chart> | ||
description: Deis Workflow Controller (API). | ||
description: Hephy Workflow Controller (API). | ||
maintainers: | ||
- name: Deis Team | ||
email: engineering@deis.com | ||
- email: team@teamhephy.com |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be something like this to keep backwars compatibility with older clusters:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to try the above and see if it works for us. 👍 Sometime before we have had problems using
. Capabilities.APIVersions.Has
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs mention that checking for resources (
apps/v1/Deployment
) requires at least Helm v2.15, but just usingapps/v1
(without a resource) should be fine, if that's specific enough.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can perhaps just check for "v1" – I think you might not find specific API groups, but you can count on support for
apps/v1
if APIVersions has "v1"There was an issue I found on the Prometheus helm chart repo that covered this, I will look to see what they settled on to solve the backwards compatibility question, and if it differs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following this suggestion in 5930851 . 👍 I found this similar example in a Datadog agent chart that looks very similar to exactly what we are doing here:
https://github.com/helm/charts/blob/2215d0f752370ae75fa54a9f62b057ed14f8e744/stable/datadog/templates/agent-clusterchecks-deployment.yaml#L2-L9
I think they are adding the last
else
in the end to make sure it tries to get deployed using the default apiVersion asapps/v1
even if the deployer agent (Helm or whatever...) does not have permission to view.Capabilities.APIVersions
?