Add support `cpu.cores` hardware requirement for mrack #2728

skycastlelily · 2024-03-04T15:07:29Z

Pull Request Checklist

implement the feature
extend the test coverage
mention the version
include a release note

happz · 2024-04-04T07:33:31Z

@skycastlelily hello, please, rebase & add a simple unit test similar to https://github.com/teemtee/tmt/blob/main/tests/unit/provision/mrack/test_hw.py#L277? This PR is fairly simple, it should be easy to get it reviewed and merged quickly.

skycastlelily · 2024-04-08T07:50:36Z

Really sorry for the late reply, I'm just back from my national holiday.

This PR is fairly simple, This PR is fairly simple, it should be easy to

get it reviewed and merged quickly. Yes ,and updated^^

…

On Thu, Apr 4, 2024 at 3:33 PM Miloš Prchlík ***@***.***> wrote: @skycastlelily <https://github.com/skycastlelily> hello, please, rebase & add a simple unit test similar to https://github.com/teemtee/tmt/blob/main/tests/unit/provision/mrack/test_hw.py#L277?? This PR is fairly simple, it should be easy to get it reviewed and merged quickly. — Reply to this email directly, view it on GitHub <#2728 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFR23EHT2UQ34J6QMBAGPDY3T66DAVCNFSM6AAAAABEFL53S6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZWGQYDKMBVGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

happz · 2024-04-10T13:54:18Z

Sorry for not mentioning it in the previous post, but a short release note, similar to https://github.com/teemtee/tmt/blob/main/docs/releases.rst?plain=1#L44, would be nice. No more comments from my side.

Maybe merge it into a single note for this PR and #2733?

Oh, and one more thing: please, update specs/hardware/cpu.fmf, in a way similar to https://github.com/teemtee/tmt/pull/2733/files#diff-844c430661f020411c529315cabf0d4099728fc3226a2b448ceacfc6637fe550, and mention beaker gained support of new requirement.

skycastlelily · 2024-04-12T07:05:31Z

updated^^

…

On Wed, Apr 10, 2024 at 9:54 PM Miloš Prchlík ***@***.***> wrote: Sorry for not mentioning it in the previous post, but a short release note, similar to https://github.com/teemtee/tmt/blob/main/docs/releases.rst?plain=1#L44, would be nice. No more comments from my side. Maybe merge it into a single note for this PR and #2733 <#2733?>? — Reply to this email directly, view it on GitHub <#2728 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFR23EOLDLLBHGPW5QJT4DY4VACBAVCNFSM6AAAAABEFL53S6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBXGYYTMMRYGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

therazix · 2024-04-17T14:52:37Z

Oh, and one more thing: please, update specs/hardware/cpu.fmf, in a way similar to https://github.com/teemtee/tmt/pull/2733/files#diff-844c430661f020411c529315cabf0d4099728fc3226a2b448ceacfc6637fe550, and mention beaker gained support of new requirement.

@skycastlelily Could you please update the specs/hardware/cpu.fmf as well?

skycastlelily · 2024-04-18T01:28:31Z

Could you please update the specs/hardware/cpu.fmf as well?

Thanks for your review,updated:)

…

On Wed, Apr 17, 2024 at 10:53 PM Filip Vágner ***@***.***> wrote: Oh, and one more thing: please, update specs/hardware/cpu.fmf, in a way similar to https://github.com/teemtee/tmt/pull/2733/files#diff-844c430661f020411c529315cabf0d4099728fc3226a2b448ceacfc6637fe550, and mention beaker gained support of new requirement. @skycastlelily <https://github.com/skycastlelily> Could you please update the specs/hardware/cpu.fmf as well? — Reply to this email directly, view it on GitHub <#2728 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFR23BBWNIVL5E4HO3C623Y52EEZAVCNFSM6AAAAABEFL53S6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGQ2TCNRSGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

therazix · 2024-04-18T10:27:02Z

Just a couple of things. Shouldn't the release note be for version 1.33 instead of 1.32? The same applies to the versionchanged.

Also, cpu.cores should probably be added to the SUPPORTED_HARDWARE_CONSTRAINTS list here:

tmt/tmt/steps/provision/mrack.py

Lines 51 to 62 in 22731b9

    
           SUPPORTED_HARDWARE_CONSTRAINTS: list[str] = [ 
        
               'cpu.flag', 
        
               'cpu.processors', 
        
               'cpu.model', 
        
               'disk.size', 
        
               'disk.model_name', 
        
               'disk.driver', 
        
               'hostname', 
        
               'memory', 
        
               'virtualization.is_virtualized', 
        
               'zcrypt', 
        
               ]

skycastlelily · 2024-04-18T14:15:55Z

Updated,thanks for your review again,and sorry for failing to find them by myself:)

…

On Thu, Apr 18, 2024 at 6:27 PM Filip Vágner ***@***.***> wrote: Just a couple of things. Shouldn't the release note be for version 1.33 instead of 1.32? The same applies to the versionchanged. Also, cpu.cores should probably be added to the SUPPORTED_HARDWARE_CONSTRAINTS list here: https://github.com/teemtee/tmt/blob/22731b9761b62177de00ee7818c2f0ee4efcfe03/tmt/steps/provision/mrack.py#L51-L62 — Reply to this email directly, view it on GitHub <#2728 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFR23AK2S52AIC7SGYSUZ3Y56NYZAVCNFSM6AAAAABEFL53S6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRTGUZTQNRVGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

docs/releases.rst

psss

Thanks for implementing this!

skycastlelily · 2024-04-24T00:39:40Z

My pleasure,thanks for your review:)

…

On Tue, Apr 23, 2024 at 10:50 PM Petr Šplíchal ***@***.***> wrote: ***@***.**** approved this pull request. Thanks for implementing this! — Reply to this email directly, view it on GitHub <#2728 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFR23BDIB5IBRHW2GE35YLY6ZYKHAVCNFSM6AAAAABEFL53S6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMJXGUYDAMRYGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

psss · 2024-04-24T10:51:09Z

Seems that /tests/unit/with-system-packages/basic now fails with:

FAILED provision/mrack/test_hw.py::test_maximal_constraint - AssertionError: ...

@skycastlelily, could you please have a look?

skycastlelily · 2024-04-25T08:04:30Z

I forgot to update that testcase,should be good now:)

…

On Wed, Apr 24, 2024 at 6:51 PM Petr Šplíchal ***@***.***> wrote: Seems that /tests/unit/with-system-packages/basic now fails with: FAILED provision/mrack/test_hw.py::test_maximal_constraint - AssertionError: ... @skycastlelily <https://github.com/skycastlelily>, could you please have a look? — Reply to this email directly, view it on GitHub <#2728 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFR23D622PWBCBPKSIBNC3Y66FDHAVCNFSM6AAAAABEFL53S6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZUGY3DKMZUGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

psss · 2024-04-25T10:24:23Z

Test failures are irrelevant, merged.

skycastlelily requested review from dav-pascual, psss, lukaszachy, happz, thrix and janhavlin as code owners March 4, 2024 15:07

happz added area | hardware Implementation of hardware requirements plugin | mrack The beaker provision plugin labels Mar 4, 2024

happz added this to the 1.33 milestone Mar 4, 2024

skycastlelily force-pushed the cpu-core branch from 7ccdfea to f54b795 Compare March 5, 2024 07:03

skycastlelily changed the title ~~Add support hardware requirement for mrack~~ Add support cpu.cores hardware requirement for mrack Mar 5, 2024

skycastlelily force-pushed the cpu-core branch from f54b795 to 9d45c07 Compare April 8, 2024 07:49

happz approved these changes Apr 15, 2024

View reviewed changes

therazix approved these changes Apr 19, 2024

View reviewed changes

docs/releases.rst Outdated Show resolved Hide resolved

psss added the ci | full test Pull request is ready for the full test execution label Apr 23, 2024

psss force-pushed the cpu-core branch from 6133f56 to c51719a Compare April 23, 2024 14:48

psss approved these changes Apr 23, 2024

View reviewed changes

skycastlelily added 3 commits April 25, 2024 04:01

Add support cpu.cores hardware requirement for mrack

c9a0d3b

squash: add release note

21be96e

squash: update the spec file

1fa2b5e

skycastlelily added 3 commits April 25, 2024 04:01

squash: version change, add cpu.cores to constraint list

ee7c405

squash: add space, all capital

315de3b

squash: update test_maximal_constraint testcase

ec59c79

skycastlelily force-pushed the cpu-core branch from c51719a to ec59c79 Compare April 25, 2024 08:03

happz enabled auto-merge (squash) April 25, 2024 08:27

psss disabled auto-merge April 25, 2024 10:23

psss merged commit 756a288 into teemtee:main Apr 25, 2024
14 of 20 checks passed

psss self-assigned this Apr 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support `cpu.cores` hardware requirement for mrack #2728

Add support `cpu.cores` hardware requirement for mrack #2728

skycastlelily commented Mar 4, 2024 •

edited by happz

Loading

happz commented Apr 4, 2024

skycastlelily commented Apr 8, 2024 via email

happz commented Apr 10, 2024 •

edited

Loading

skycastlelily commented Apr 12, 2024 via email

therazix commented Apr 17, 2024

skycastlelily commented Apr 18, 2024 via email

therazix commented Apr 18, 2024

skycastlelily commented Apr 18, 2024 via email

psss left a comment

skycastlelily commented Apr 24, 2024 via email

psss commented Apr 24, 2024

skycastlelily commented Apr 25, 2024 via email

psss commented Apr 25, 2024

Add support cpu.cores hardware requirement for mrack #2728

Add support cpu.cores hardware requirement for mrack #2728

Conversation

skycastlelily commented Mar 4, 2024 • edited by happz Loading

happz commented Apr 4, 2024

skycastlelily commented Apr 8, 2024 via email

happz commented Apr 10, 2024 • edited Loading

skycastlelily commented Apr 12, 2024 via email

therazix commented Apr 17, 2024

skycastlelily commented Apr 18, 2024 via email

therazix commented Apr 18, 2024

skycastlelily commented Apr 18, 2024 via email

psss left a comment

Choose a reason for hiding this comment

skycastlelily commented Apr 24, 2024 via email

psss commented Apr 24, 2024

skycastlelily commented Apr 25, 2024 via email

psss commented Apr 25, 2024

Add support `cpu.cores` hardware requirement for mrack #2728

Add support `cpu.cores` hardware requirement for mrack #2728

skycastlelily commented Mar 4, 2024 •

edited by happz

Loading

happz commented Apr 10, 2024 •

edited

Loading