Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Alpine Linux support #2828

Merged
merged 8 commits into from
May 1, 2024
Merged

Fix Alpine Linux support #2828

merged 8 commits into from
May 1, 2024

Conversation

thrix
Copy link
Collaborator

@thrix thrix commented Apr 4, 2024

The previous patches did not update the prepare install plugin. Add a functional test to verify the alpine image is really testable.

Pull Request Checklist

  • implement the feature
  • extend the test coverage

@thrix thrix added this to the 1.33 milestone Apr 4, 2024
@happz happz added step | prepare Stuff related to the prepare step area | package managers Changes related to implementations of package managers labels Apr 15, 2024
@thrix
Fix Alpine Linux support
06025bc 
The previous patches did not update the `prepare` install plugin.
Add a functional test to verify the alpine image is really testable.

Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
@thrix
Use tmt.utils.DEFAULT_SHELL
b71f890 
Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
@thrix
Capitalize default shell
87fdb23 
Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
@thrix
Fix pyproject.toml
e652c47 
Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
@thrix thrix requested a review from happz April 30, 2024 09:39
@thrix
Fix tests image tag
3203fa0 
Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
@thrix
Fix makefile target
088b6a1 
Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
@happz happz added the ci | full test Pull request is ready for the full test execution label Apr 30, 2024
@happz
Copy link
Collaborator

happz commented Apr 30, 2024

/packit test

psss
psss previously requested changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Looks good, just two comments.

plans/main.fmf Outdated Show resolved Hide resolved
tests/provision/container/alpine/test.sh Outdated Show resolved Hide resolved
@lukaszachy lukaszachy mentioned this pull request Apr 30, 2024
Merged
2 tasks
@thrix thrix requested a review from psss April 30, 2024 16:23
@thrix thrix dismissed psss’s stale review April 30, 2024 18:54

This was addressed by happz

@happz
Copy link
Collaborator

happz commented May 1, 2024

/packit test

@happz happz enabled auto-merge (squash) May 1, 2024 08:15
@happz happz merged commit 1a3c738 into main May 1, 2024
20 checks passed
@happz happz deleted the fix-prepare-install-apk branch May 1, 2024 09:07
@psss psss added the priority | must high priority, must be included in the next release label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@lukaszachy lukaszachy lukaszachy approved these changes

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer

@psss psss Awaiting requested review from psss psss is a code owner

Assignees
No one assigned
Labels
area | package managers Changes related to implementations of package managers ci | full test Pull request is ready for the full test execution priority | must high priority, must be included in the next release step | prepare Stuff related to the prepare step
Projects
None yet
Milestone
1.33
Development

Successfully merging this pull request may close these issues.
4 participants
@thrix @happz @lukaszachy @psss