Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix installation of packages from files #2914

Merged
merged 5 commits into from
May 7, 2024
Merged

Fix installation of packages from files #2914

merged 5 commits into from
May 7, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented May 7, 2024

Fixes #2911

Pull Request Checklist

  • implement the feature
  • extend the test coverage

@happz happz added bug Something isn't working step | prepare Stuff related to the prepare step labels May 7, 2024
@happz happz added this to the 1.33 milestone May 7, 2024
@happz happz added the ci | full test Pull request is ready for the full test execution label May 7, 2024
@happz
Copy link
Collaborator Author

happz commented May 7, 2024

/packit test

psss
psss requested changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much for fixing this! Added a few comments.

tests/prepare/install/test.sh Show resolved Hide resolved
tests/prepare/install/test.sh Show resolved Hide resolved
tmt/package_managers/__init__.py Outdated Show resolved Hide resolved
@psss psss added the priority | must high priority, must be included in the next release label May 7, 2024
@psss psss merged commit 142f3d1 into main May 7, 2024
20 of 21 checks passed
@psss psss deleted the package-manager-fix-local-no-check branch May 7, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszachy lukaszachy lukaszachy approved these changes

@psss psss psss approved these changes

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
bug Something isn't working ci | full test Pull request is ready for the full test execution priority | must high priority, must be included in the next release step | prepare Stuff related to the prepare step
Projects
None yet
Milestone
1.33
Development

Successfully merging this pull request may close these issues.

Installing a local package does not work
3 participants
@happz @lukaszachy @psss