Support location.lab-controller hw requirement for mrack
#2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skycastlelily
requested review from
dav-pascual,
psss,
lukaszachy,
happz,
thrix and
janhavlin
as code owners
skycastlelily
force-pushed
the
location
branch
3 times, most recently
from
fa69ea0
to
5be6995
Compare
happz
reviewed
May 15, 2024
happz
reviewed
May 15, 2024
|
Much better than mine,I knew it😁 Updated^^
…On Wed, May 15, 2024 at 5:11 PM Miloš Prchlík ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In spec/hardware/location.fmf
<#2927 (comment)>:
> @@ -12,8 +12,13 @@ description: |
.. versionchanged:: 1.33
Added ``location.lab-controller`` into specification.
+ .. warning::
+
+ `like` operation is not supported by lab-controller, only `!=` and `==`
"like operation" is an implementation detail of Beaker, let's not leak
it. How about something more verbose?
.. warning::
Because of Beaker limitation, ``~`` and ``!~`` operators commonly used with text-like
HW requirements cannot be used with ``lab-controller``. Only ``==`` and ``!=``
operators are supported.
—
Reply to this email directly, view it on GitHub
<#2927 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFR23D6ICXWGCUDINUPFKLZCMREBAVCNFSM6AAAAABHT2DWLKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJXGM4DENJVGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
happz
added
step | provision
|
@skycastlelily when you have some spare time, rebase on top of the recent main, please, and resolve conflicts. |
|
Updated^^
…On Sat, Jun 15, 2024 at 4:39 PM Miloš Prchlík ***@***.***> wrote:
@skycastlelily <https://github.com/skycastlelily> when you have some
spare time, rebase on top of the recent main, please, and resolve conflicts.
—
Reply to this email directly, view it on GitHub
<#2927 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFR23DRHE5PCA33SQ2J3STZHP4THAVCNFSM6AAAAABHT2DWLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRZGIYTGNBWHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
happz
approved these changes
Jun 18, 2024
therazix
approved these changes
Jun 27, 2024
happz
added
the
status | ready for merge
|
/packit build |
|
Unrelated failures, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist