Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of test coverage for extended features of reportportal plugin #2929

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Addition of test coverage for extended features of reportportal plugin #2929

merged 2 commits into from
Aug 7, 2024

Conversation

4N0body5
Copy link
Collaborator

@4N0body5 4N0body5 commented May 13, 2024 •
edited
Loading

This is a follow up of #2305, including a detailed test coverage and documentation modifications.

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

happz
happz reviewed May 13, 2024
View reviewed changes
spec/plans/report.fmf Outdated Show resolved Hide resolved
@4N0body5 4N0body5 force-pushed the reportportalAPI branch 3 times, most recently from 7ad0a19 to c816075 Compare July 4, 2024 00:54
@4N0body5 4N0body5 requested a review from happz July 4, 2024 00:54
@4N0body5 4N0body5 added this to the 1.35 milestone Jul 4, 2024
thrix
thrix reviewed Aug 1, 2024
View reviewed changes
spec/plans/report.fmf Outdated Show resolved Hide resolved
thrix
thrix reviewed Aug 1, 2024
View reviewed changes
spec/plans/report.fmf Outdated Show resolved Hide resolved
@thrix thrix self-requested a review August 1, 2024 12:03
thrix
thrix approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@happz happz added status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. plugin | reportportal The reportportal report plugin ci | full test Pull request is ready for the full test execution labels Aug 6, 2024
@happz
Copy link
Collaborator

happz commented Aug 7, 2024

Unrelated failures, merging.

@happz happz merged commit e2e9bd4 into main Aug 7, 2024
19 of 20 checks passed
@happz happz deleted the reportportalAPI branch August 7, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@thrix thrix thrix approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution plugin | reportportal The reportportal report plugin status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.
3 participants
@4N0body5 @happz @thrix