Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover tmt.trying with pyright check #2942

Merged
merged 1 commit into from
May 28, 2024
Merged

Cover tmt.trying with pyright check #2942

merged 1 commit into from
May 28, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented May 19, 2024

Pull Request Checklist

  • implement the feature

@happz happz added status | need tests Test coverage to be added for the affected code code | type annotations Related to type annotations and type cleanup code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels May 19, 2024
@happz happz added this to the 1.34 milestone May 19, 2024
psss
psss approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@psss psss changed the title Cover tmt.trying with pyright check Cover tmt.trying with pyright check May 28, 2024
@psss psss added the ci | full test Pull request is ready for the full test execution label May 28, 2024
@psss psss added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label May 28, 2024
@happz happz added test coverage Improvements or additions to test coverage of tmt itself and removed status | need tests Test coverage to be added for the affected code labels May 28, 2024
@happz
Copy link
Collaborator Author

happz commented May 28, 2024

No functional changes, and once RPM builds finished, we know the annotation changes are fine. Merging without waiting for functional tests.

@happz happz merged commit 0711a2e into main May 28, 2024
11 of 19 checks passed
@happz happz deleted the pyright-tmt-try branch May 28, 2024 13:15
happz added a commit that referenced this pull request Jun 2, 2024
@happz
Cover tmt.trying with pyright check (#2942)
2f74f99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

@therazix therazix therazix approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. code | type annotations Related to type annotations and type cleanup status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. test coverage Improvements or additions to test coverage of tmt itself
Projects
None yet
Milestone
1.34
Development

Successfully merging this pull request may close these issues.
3 participants
@happz @psss @therazix