Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon to tmt docs #3021

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Add favicon to tmt docs #3021

merged 2 commits into from
Jun 26, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Jun 18, 2024

Pull Request Checklist

  • implement the feature

@happz happz added the documentation Improvements or additions to documentation label Jun 18, 2024
@happz happz added this to the 1.35 milestone Jun 18, 2024
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the improvement. Thinking a bit about the icon size: Currently the image is 700x700 and the size is 432K, so the icon is larger then the page content :) But it will be cached, I guess, so probably not worth it?

@happz
Copy link
Collaborator Author

happz commented Jun 24, 2024

Nice! Thanks for the improvement. Thinking a bit about the icon size: Currently the image is 700x700 and the size is 432K, so the icon is larger then the page content :) But it will be cached, I guess, so probably not worth it?

It will be cached for sure, and we definitely can create a smaller one :)

@psss
Copy link
Collaborator

psss commented Jun 25, 2024

Ok :) Adding here: teemtee/docs#5

@happz
Copy link
Collaborator Author

happz commented Jun 25, 2024

@psss done.

@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jun 25, 2024
@happz
Copy link
Collaborator Author

happz commented Jun 26, 2024

Documentation-only, not waiting for functional tests to complete.

@happz happz merged commit cd0b6e3 into main Jun 26, 2024
9 of 19 checks passed
@happz happz deleted the docs-add-favicon branch June 26, 2024 12:50
@martinhoyer
Copy link
Collaborator

hah, I totally missed this and doing the same lol.
https://github.com/martinhoyer/tmt/tree/favicon-logo

@psss is the logo available in other formats or gimp files?

@happz you're using way to large resolution for the favicon here I'm afraid. Also not sure if all browsers are happy when it's not .ico.

@martinhoyer
Copy link
Collaborator

Screenshot from 2024-07-02 14-51-40
See the .ico from #3072 (on the left) vs tmt.readthedocs.io/en/latest/

@happz
Copy link
Collaborator Author

happz commented Jul 2, 2024

@martinhoyer Yeah, I didn't bother, I wouldn't even notice the image looks a bit weird on my screen. I guess it's like the sound quality, at some point my human ear don't hear the difference :)

@martinhoyer
Copy link
Collaborator

@martinhoyer Yeah, I didn't bother, I wouldn't even notice the image looks a bit weird on my screen. I guess it's like the sound quality, at some point my human ear don't hear the difference :)

/me hiding his audio equipment 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants