Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish docs of the avc test check #3029

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Polish docs of the avc test check #3029

merged 2 commits into from
Jul 16, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Jun 19, 2024

Pull Request Checklist

  • implement the feature

@happz happz added documentation Improvements or additions to documentation code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. labels Jun 19, 2024
@happz happz added this to the 1.35 milestone Jun 19, 2024
martinhoyer
martinhoyer approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@martinhoyer martinhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just minor nitpick.
Also thinking whether it would make sense to mention AVC means Access Vector Cache, but probably nah?

tmt/checks/avc.py Outdated Show resolved Hide resolved
thrix
thrix approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jul 16, 2024
happz and others added 2 commits July 16, 2024 16:10
psss
psss approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@psss
Copy link
Collaborator

psss commented Jul 16, 2024

Docs change & docs building passed --> merging.

@psss psss merged commit 1b3b681 into main Jul 16, 2024
9 of 19 checks passed
@psss psss deleted the docs-plugins-avc branch July 16, 2024 14:24
@psss psss changed the title Polish docs of AVC test check Polish docs of the avc test check Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrix thrix thrix approved these changes

@psss psss psss approved these changes

@martinhoyer martinhoyer martinhoyer approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. documentation Improvements or additions to documentation status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.
4 participants
@happz @psss @thrix @martinhoyer