Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "common keys" section of plugin docs to top of the page #3047

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Move "common keys" section of plugin docs to top of the page #3047

merged 4 commits into from
Jul 31, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Jun 26, 2024

This is shared among all plugins of a step, and it's not necessary to repeat it for every plugin.

Pull Request Checklist

  • implement the feature

@happz happz added documentation Improvements or additions to documentation code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. labels Jun 26, 2024
@happz happz added this to the 1.35 milestone Jun 26, 2024
@thrix thrix changed the title Move "common keys" section of plugn docs to top of the page Move "common keys" section of plugin docs to top of the page Jul 25, 2024
@thrix
Copy link
Collaborator

thrix commented Jul 25, 2024

@happz there is a typo in the commit message plugn

thrix
thrix approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@happz happz force-pushed the docs-plugins-move-common-keys-to-top-of-page branch 2 times, most recently from d700456 to a2af3a8 Compare July 29, 2024 08:20
@happz happz requested a review from thrix July 30, 2024 12:54
thrix
thrix approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jul 31, 2024
@happz happz force-pushed the docs-plugins-move-common-keys-to-top-of-page branch from dad4053 to 5870309 Compare July 31, 2024 13:28
@happz
Copy link
Collaborator Author

happz commented Jul 31, 2024

Documentation-only, merging.

@happz happz merged commit 74d216f into main Jul 31, 2024
12 of 20 checks passed
@happz happz deleted the docs-plugins-move-common-keys-to-top-of-page branch July 31, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrix thrix thrix approved these changes

@martinhoyer martinhoyer martinhoyer approved these changes

@therazix therazix therazix approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. documentation Improvements or additions to documentation status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.
4 participants
@happz @thrix @martinhoyer @therazix