Task #200127 : Sentry Setup with BreadCrumbs and captureException for All Cron Job #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… list fetch for user create collection and AssociateFacesCommand
…, created 3 cron job, user creation, face indexing, mark attendance
…removed all success console log, added error.stack and proper return response while exception occured, solved required code smells in sonarcloud, add custom cron job timer, first cron runs for each hours 5th minute eg: 10:05am, 11::05am, 2nd cron runs for each hours 15th minute eg: 10:15am, 11::15am, 3rd cron runs for each hours 25th minute eg: 10:25am, 11::25am
…adcrumb object response
manojLondhe
requested changes
Oct 20, 2023
src/src/sentry.filter.ts
Outdated
| @@ -0,0 +1,12 @@ | |||
| import { Catch, ArgumentsHost } from '@nestjs/common'; | |||
There was a problem hiding this comment.
-
how this is different from
~/src/src/common/interceptors/sentry.interceptor.ts? -
do we need both?
-
if we only need this move to ~/src/src/common/filters
There was a problem hiding this comment.
it is working without sentry global filter so I removed sentry global filter. Also as we discussed, I also removed transactions from 3 cron job.
| @@ -59,25 +61,39 @@ export class AwsRekognitionService { | |||
| ); | |||
| //.promise(); | |||
There was a problem hiding this comment.
remove old commented code / console logs
…e, added detail message format for breadcrumb
rushi-tekdi
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Created SentryFilter class which extends BaseExceptionFilter
-Used this SentryFilter as app useGlobalFilters
-Created Sentry service which contain methods addBreadcrumb, startTransaction, captureException
-Added Sentry Transaction, BreadCrumbs and captureException in 3 Cron Jobs i.e., faUserIndexing.cron, faFaceIndexing.cron, faAttendanceProcessing.cron
I have ensured that following
Pull Request Checklistis taken care of before sending this PR