-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix catalog test failures on s390x #1275
fix catalog test failures on s390x #1275
Conversation
Hi @vdemeester @vinamra28, would you please check this PR. |
test/linux-s390x.sh
Outdated
kubectl patch cm feature-flags -n tekton-pipelines -p '{"data":{"enable-step-actions":"true"}}' | ||
|
||
echo "Patch to Disable Affinity Assistant (Needed to allow binding of two PVCs for Maven-0-3 test)" | ||
kubectl patch cm feature-flags -n tekton-pipelines -p '{"data":{"disable-affinity-assistant":"true"}}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't this be done under single command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay i will try
@Basavaraju-G, can you please squash the commits? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix catalog test failures on s390x
5ad9487
to
3c6a2db
Compare
Done. |
/lgtm |
Changes
Replaces the GRADLE_IMAGE parameter for gradle/0.4 to the multi-arch alternative. Currently the image is x86 only.
Added an Extra MAVEN_IMAGE parameter which is missing for the maven-0-3 test via linux-s390x.sh script.
Added a patch command to enable Step Actions on the cluster. This is needed for stepaction test.
Added a patch command to disable Affinity Assistant on the cluster. This allow binding of two PVCs at the same time and is needed by the maven-0-3 test.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
contains
/kind <type>
. Valid types are bug, cleanup, design, documentation,feature, flake, misc, question, tep
File path follows
<kind>/<name>/<version>/name.yaml
Has
README.md
at<kind>/<name>/<version>/README.md
Has mandatory
metadata.labels
-app.kubernetes.io/version
the same as the<version>
of the resourceHas mandatory
metadata.annotations
tekton.dev/pipelines.minVersion
mandatory
spec.description
follows the conventionSee the contribution guide for more details.