Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Common Expression Language Custom Task (CELRun) #304

Closed
jerop opened this issue Jan 13, 2021 · 7 comments
Closed

Proposal: Common Expression Language Custom Task (CELRun) #304

jerop opened this issue Jan 13, 2021 · 7 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@jerop
Copy link
Member

jerop commented Jan 13, 2021

Proposal for creating tektoncd/experimental/cel to incubate Common Expression Language Custom Tasks project

Per process, this project was proposed with verbal support at the Tekton WG on Jan 13th 2021

The problem the project will solve

CEL Custom Tasks will allow us to experiment with CEL in Tekton Pipelines without adding CEL directly to the Tekton API surface

CEL Custom Tasks would be useful in evaluating more complex expressions for guarding execution of Tasks beyond what we support in WhenExpressions, read more

Related issues:

Who will own it

Updates

/cc Governing Board: @abayer @vdemeester @bobcatfish @afrittoli @imjasonh

@jerop jerop changed the title Proposal: CELRun - Common Expression Language Custom Task Proposal: Common Expression Language Custom Task (CELRun) Jan 13, 2021
@afrittoli
Copy link
Member

+100

This would be useful to simplify how we use conditions today in dogfooding, so I'd be happy to start running the custom task controller in dogfooding from the experimental repo.

@imjasonh
Copy link
Member

+1, happy to co-own and help update and contribute cel-task as a base (or start from scratch if that's better).

🎉

@jerop
Copy link
Member Author

jerop commented Jan 13, 2021

+1, happy to co-own and help update and contribute cel-task as a base (or start from scratch if that's better).

yes yes, we can build on it, thanks for your contributions @imjasonh!

some changes I propose we make include:

  • when the CEL expression is valid and is evaluated successfully, the ConditionSucceeded in status of the CELRun is set to True regardless of the expression evaluation result and the CELRun produces a Result representing the expression evaluation result (True/False)
  • when the CEL expression is invalid or any other error is encountered, the ConditionSucceeded in status of the CELRun is set to False

this will allow us to distinguish between errors and the expression evaluating to false, which was one of the issues with Conditions

@imjasonh
Copy link
Member

some changes I propose we make include:

Yeah those both sound like good improvements. 👍

@jerop
Copy link
Member Author

jerop commented Jan 13, 2021

thanks for the quick review @imjasonh and @afrittoli

created the project folder in tektoncd/experimental#691

tekton-robot pushed a commit to tektoncd/experimental that referenced this issue Jan 14, 2021
Creating a folder for incubating CELRun project which will provide a
Common Expression Language Custom Task, as proposed in tektoncd/community#304
and adding the OWNERS to approve and review contributions to the project
chandanikumari pushed a commit to chandanikumari/experimental that referenced this issue Jan 27, 2021
Creating a folder for incubating CELRun project which will provide a
Common Expression Language Custom Task, as proposed in tektoncd/community#304
and adding the OWNERS to approve and review contributions to the project
@jerop
Copy link
Member Author

jerop commented Jan 28, 2021

Common Expression Language Custom Tasks is available in https://github.com/tektoncd/experimental/tree/master/cel

@jerop jerop closed this as completed Jan 28, 2021
@jerop jerop reopened this Feb 23, 2021
@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 25, 2021
@jerop jerop closed this as completed Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants