Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0005: Make Tekton Bundles implementable #205

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

pierretasci
Copy link
Contributor

This moves the Tekton Bundle TEP into implementation (PR here tektoncd/pipeline#3142).

It also updates the spec to match the current proposal.

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 15, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One general question (to @tektoncd/core-maintainers @pierretasci @coryrc and all really) :
As of today,, TEP-0005 is only about the tekton bundle format (aka oci image, layers, …) and not on how it is used. To get tektoncd/pipeline#3142 mergeable, we would probably either need to update this TEP with a part on this (how it affects the api, … — based on the PR discussions) or a new TEP (that could be #210) ?

@vdemeester vdemeester added the kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). label Sep 17, 2020
@pierretasci
Copy link
Contributor Author

One general question (to @tektoncd/core-maintainers @pierretasci @coryrc and all really) :
As of today,, TEP-0005 is only about the tekton bundle format (aka oci image, layers, …) and not on how it is used. To get tektoncd/pipeline#3142 mergeable, we would probably either need to update this TEP with a part on this (how it affects the api, … — based on the PR discussions) or a new TEP (that could be #210) ?

Obviously I am quite biased here but I have already put a lot of legwork into this design well before the TEP process. The bundle URL field for example was already discussed and generally agreed upon in the API working group before the TEP process was finalized. This isn't me trying to get out of doing extra work. Rather, I just mean to point out that these discussions have been had.

I can update this TEP with the API change if need be but my preference would be to move this into merge especially since the API change is more or less an implementation detail at this point.

@vdemeester
Copy link
Member

Obviously I am quite biased here but I have already put a lot of legwork into this design well before the TEP process. The bundle URL field for example was already discussed and generally agreed upon in the API working group before the TEP process was finalized. This isn't me trying to get out of doing extra work. Rather, I just mean to point out that these discussions have been had.

I can update this TEP with the API change if need be but my preference would be to move this into merge especially since the API change is more or less an implementation detail at this point.

So from the TEP process, "This means any change that may impact any other community project in a way should be proposed as a TEP. Those changes could be for technical reasons, or adding new features, or deprecating then removing old features.". This means, the API part would need a TEP. I do agree with you that this did get discussed during API WG before the TEP process but still, now that the process is there, we should try to follow it as much as possible. So I would advocate to quickly update the TEP to add the API part so that we can go on with the implementation. cc @tektoncd/core-maintainers

I also think, based on the implementation PR discussion, there is still some discussion to have / happening that is buying us time to update the TEP 😉

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 17, 2020
@vdemeester vdemeester changed the title Make Tekton Bundles implementable TEP-0005: Make Tekton Bundles implementable Sep 21, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020
@pierretasci
Copy link
Contributor Author

/assign kimsterv

@vdemeester
Copy link
Member

/assign @bobcatfish @imjasonh @afrittoli

@imjasonh
Copy link
Member

/lgtm

@imjasonh
Copy link
Member

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2020
@tekton-robot tekton-robot merged commit e103799 into tektoncd:master Sep 23, 2020
@pierretasci pierretasci deleted the update-tep branch September 23, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Implementable
Development

Successfully merging this pull request may close these issues.

7 participants