Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0086: Changing the way result parameters are stored #521

Merged
merged 6 commits into from
May 9, 2022

Commits on Feb 1, 2022

  1. Proposed TEP-0086 Changing the way result parameters are stored

    - Design details updated
    - 5th option based on API WG Alternate discussion
    - Updated based on TEP review comments
    - Updated based on Result Collector Sidecar
    - Added Result Collector Sidecar author
    - Updated with additional PipelineResource alternative'
    - Updated based on PR comments
    - Moved the result sidecar solution to alternative and marked as TBD
    - Updated based on WG review feedback
    tlawrie committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    ceb56d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. Configuration menu
    Copy the full SHA
    b697683 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. [TEP-0086] Update requirements and alternatives after recent discussi…

    …on 📓
    
    In [a recent API working group meeting](https://docs.google.com/document/d/17PodAxG8hV351fBhSu7Y_OIPhGTVgj6OJ2lPphYYRpU/edit#heading=h.ux4qhojeot6k)
    we talked through the proposal that was currently looking the most
    appealing (sidecar + HTTP service) and @skaegi brought up some potential
    requirements that might change this, and also volunteered to find
    someone to work on a POC for a logs based solution before we disregard
    that entirely.
    
    Personally I agree that it would be best if we could keep the TaskRun to
    be the source of truth for the results themselves, but that would mean
    agreeing to an upper limit on result size (at least).
    
    I've tried to reflect the above and generally organize the TEP a bit,
    and add some missing stuff:
    * Moved some points from Goals to requirements (really one goal overall,
      rest of the items are constraints on how we accomplish that goal)
    * Add requirements we've been discussing, trying to highlight the ones
      that are newer and other collaborators might disagree with
    * Expanding the risks section a bit
    * Added some high level performance details
    * Suggested potential next steps to unblock this
    * Added more detials to auth/encryption/defined interface notes from
      our previous one off meeting
      [notes](https://hackmd.io/YU_g27vRS2S5DwfBXDGpYA?view)
    * Filled in the design evaluation
    * Added some drawbacks
    * Separated "SideCar Result References" into two alternatives (which are
      not mutually exclusive)
    * Added using PVCs as an alternative
    * Added some cons to log based solution
    bobcatfish committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    a4df1c1 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Drop the proposal and update requirements

    I noticed this TEP is not yet accepted and merged. This TEP is stuck in the
    review process. Dropping the proposal and design details based on the
    recent discussion in the API WG. This TEP instead now contains a list of
    alternatives. If we can merge this without proposal, it opens up an opportunity
    for the community to create a PoC and evaluate which solution fits best for
    the set of the requirements.
    
    Moving the proposal and design details under the first alternative, making it
    more like a TEP within TEP.
    
    One major change here is the requirement section in which task results as part
    of the taskRun status is listed as a requirement with the flexible design for
    the use cases which would like to avoid it.
    
    Updated the toc.
    pritidesai committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    0aa18ec View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. Update teps/0086-changing-the-way-result-parameters-are-stored.md

    Co-authored-by: Jerop Kipruto <jerop@google.com>
    tlawrie and jerop committed May 9, 2022
    Configuration menu
    Copy the full SHA
    1293761 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a96b9b8 View commit details
    Browse the repository at this point in the history