Embed PipelineResources in PipelineRun and TaskRun #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #240
This PR updates our PipelineRuns and TaskRuns to use an embedded PipelineResourceSpec. So, we will no longer encounter race conditions between the PipelineResources and PipelineRun/TaskRun.
I updated the Gopkg.toml file to use revision
8871979dfc08fb65ae544c6ad2de83f8bab617b0
of tektoncd/pipeline, so we can ensure tektoncd/pipeline#1324 will be available.Some additional changes had to be made to update to this newer version of Tekton Pipelines. The most notable change is with parameters, where we now must account for the
ArrayOrString
struct.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.