Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed PipelineResources in PipelineRun and TaskRun #296

Closed
wants to merge 1 commit into from

Conversation

ncskier
Copy link
Member

@ncskier ncskier commented Oct 17, 2019

Changes

Fixes #240

This PR updates our PipelineRuns and TaskRuns to use an embedded PipelineResourceSpec. So, we will no longer encounter race conditions between the PipelineResources and PipelineRun/TaskRun.

I updated the Gopkg.toml file to use revision 8871979dfc08fb65ae544c6ad2de83f8bab617b0 of tektoncd/pipeline, so we can ensure tektoncd/pipeline#1324 will be available.

Some additional changes had to be made to update to this newer version of Tekton Pipelines. The most notable change is with parameters, where we now must account for the ArrayOrString struct.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Fixes tektoncd#240
PR tektoncd/pipeline#1324 makes it possible to
embed PipelineResourceSpecs into a PipelineRun.

This PR updates our PipelineRuns and TaskRuns to use an embedded
PipelineResourceSpec. So, we will no longer encounter race conditions
between the PipelineResources and PipelineRun/TaskRun.

The Gopkg.toml file was updated to use revision
8871979dfc08fb65ae544c6ad2de83f8bab617b0 of tektoncd/pipeline, so we can
ensure PR 1324 will be available.
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2019
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mnuttall
You can assign the PR to them by writing /assign @mnuttall in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 17, 2019
@ncskier ncskier marked this pull request as ready for review October 17, 2019 22:05
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2019
@ncskier
Copy link
Member Author

ncskier commented Oct 17, 2019

/uncc @jessm12
/uncc @CarolynMabbott
/cc @a-roberts
/cc @dibbles

@tekton-robot tekton-robot requested review from a-roberts and dibbles and removed request for CarolynMabbott and jessm12 October 17, 2019 22:07
@ncskier
Copy link
Member Author

ncskier commented Oct 18, 2019

/hold
I talked with @a-roberts and @mnuttall, and we're going to wait on this change until we know we can use this change & Tekton Pipelines version > v0.7.0 in the next kabanero release. Some more info in this comment.

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2019
@mnuttall
Copy link
Contributor

Hi @ncskier post-Triggers, we need updated samples for Tekton 0.8+ with the right TriggerTemplates. I think that needs a separate work item so I'll close this.

@mnuttall mnuttall closed this Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhooks extension PipelineRun sometimes doesn't have PipelineResources ready in time
3 participants