Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[task-loops] Support string input for iterate parameter #713

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

afrittoli
Copy link
Member

Changes

When the input parameter is dynamically generated, it is not
possible to produce a list. Add support for newline separated
list of items passed a single string.

This makes it possible for a task to produce a result that
is than used as iterate parameter in the task loop, and thus
to programmatically define the list of tasks to be executed.

Signed-off-by: Andrea Frittoli andrea.frittoli@gmail.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Commit messages includes a project tag in the subject - e.g. [OCI], [hub], [results], [task-loops]

See the contribution guide
for more details.

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 3, 2021
@afrittoli
Copy link
Member Author

/cc @imjasonh @vdemeester @bobcatfish

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 3, 2021
When the input parameter is dynamically generated, it is not
possible to produce a list. Add support for newline separated
list of items passed a single string.

This makes it possible for a task to produce a result that
is than used as iterate parameter in the task loop, and thus
to programmatically define the list of tasks to be executed.

Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
@afrittoli afrittoli force-pushed the support_string_iterate_param branch from f2b2aa1 to 4d47107 Compare March 3, 2021 15:35
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM 😉

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2021
@imjasonh
Copy link
Member

imjasonh commented Mar 8, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2021
@tekton-robot tekton-robot merged commit 3f44fef into tektoncd:main Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants