Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] ignore enable-tekton-oci-bundles feature flag #2344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jkandasa
Copy link
Member

Changes

  • feature flag enable-tekton-oci-bundles support removed and added into main stream. Supplying enable-tekton-oci-bundles=true can lead issue with pipeline controller. Hence ignore enable-tekton-oci-bundles values from TektonConfig CR and/or TektonPipelines CR.
  • keeping enable-tekton-oci-bundles in operator to maintain the API compatibility
  • originally removed from pipeline controller on Remove taskref/pipelineref deprecated bundle field pipeline#7789

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

pipeline feature flag `enable-tekton-oci-bundles` will be ignored.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 24, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from jkandasa after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonpipeline_defaults.go 93.4% 93.3% -0.1
pkg/reconciler/kubernetes/tektonpipeline/transform.go 78.5% 89.8% 11.3

Signed-off-by: Jeeva Kandasamy <jkandasa@redhat.com>
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonpipeline_defaults.go 93.4% 93.3% -0.1
pkg/reconciler/kubernetes/tektonpipeline/transform.go 78.5% 89.8% 11.3

@jkandasa
Copy link
Member Author

/test pull-tekton-operator-integration-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants