Enable the "gosec" linter for CI, and fix the one issue in our code.

The "issue" is actually a false positive, so it is fixed by adding an annotation.
tektoncd · Sep 26, 2019 · 4fc6231 · 4fc6231
1 parent 40e340f
commit 4fc6231
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -12,3 +12,4 @@ linters:
   - errcheck
   - gofmt
   - goimports
+  - gosec
diff --git a/pkg/apis/pipeline/v1alpha1/artifact_bucket.go b/pkg/apis/pipeline/v1alpha1/artifact_bucket.go
@@ -53,6 +53,9 @@ const (
 	ArtifactStoragePVCType = "pvc"
 )
 
+// For some reason gosec thinks this string has enough entropy to be a potential secret.
+// The nosec comment disables it for this line.
+/* #nosec */
 var secretVolumeMountPath = "/var/bucketsecret"
 
 // ArtifactBucket contains the Storage bucket configuration defined in the