Skip to content

Commit

Permalink
Fix e2e yaml false success report πŸ›ƒ
Browse files Browse the repository at this point in the history
Even if a `TaskRun`, or a `PipelineRun` fails, the script will return
an exit code 0, which will show in CI as success. This fixes that.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
  • Loading branch information
vdemeester committed Apr 26, 2019
1 parent 639b300 commit 830a169
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/e2e-tests-yaml.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ for test in taskrun pipelinerun; do
header "Running YAML e2e tests for ${test}s"
if ! run_yaml_tests ${test}; then
echo "ERROR: one or more YAML tests failed"
failed=1
output_yaml_test_results ${test}
output_pods_logs ${test}
failed=1
fi
done

Expand Down

0 comments on commit 830a169

Please sign in to comment.