Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design image type #12

Closed
bobcatfish opened this issue Sep 7, 2018 · 1 comment
Closed

Design image type #12

bobcatfish opened this issue Sep 7, 2018 · 1 comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@bobcatfish
Copy link
Collaborator

bobcatfish commented Sep 7, 2018

The work for this task is to design this feature and present one or more proposals (before implementing).

Expected Behavior

One of the features we want the Pipeline to have is to have strong typing around concepts that will be used commonly in k8s centric CI/CD pipelines.

One of the concepts we want to have strong typing around is a "container image", which is something that could be produced by a Task as an output, and published to an artifact store, and may be used by subsequent Tasks for testing or deploying.

Some attributes we'd probably like include:

  • name
  • tag
  • digest (could be unknown until the image is built)

Actual Behavior

This concept only exists theoretically, but in this example pipeline we have a builtImage attribute on an artifact store binding, declaring what we'd like the built image to be called:

image

Additional Info

@bobcatfish bobcatfish added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 12, 2018
@bobcatfish
Copy link
Collaborator Author

Closing this issue as @pivotal-nader-ziada and @shashwathi added an initial version of the image type at https://github.com/knative/build-pipeline/blob/1c4deea8de70d40ded6cab8d64fe303d65ce2970/pkg/apis/pipeline/v1beta1/image_source.go in #39 !

lumjjb pushed a commit to lumjjb/pipeline that referenced this issue Mar 21, 2022
* added condition helper and cleanup if statement

Signed-off-by: pxp928 <parth.psu@gmail.com>

* added missing unit test

Signed-off-by: pxp928 <parth.psu@gmail.com>

* fixed based on comments

Signed-off-by: pxp928 <parth.psu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

1 participant