Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML test pass when applying example fails #1396

Closed
afrittoli opened this issue Oct 9, 2019 · 0 comments · Fixed by #1399
Closed

YAML test pass when applying example fails #1396

afrittoli opened this issue Oct 9, 2019 · 0 comments · Fixed by #1399
Assignees
Labels
area/testing Issues or PRs related to testing priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@afrittoli
Copy link
Member

Expected Behavior

If something goes wrong when applying the example YAMLs, tests should fail

Actual Behavior

I1008 11:21:13.361] =============================================
I1008 11:21:13.362] ==== RUNNING YAML E2E TESTS FOR TASKRUNS ====
I1008 11:21:13.362] =============================================
I1008 11:21:13.362] >> Starting tests for the resource taskrun
I1008 11:21:13.362] >> Creating resources taskrun
I1008 11:21:13.758] error: error when retrieving current configuration of:
I1008 11:21:13.759] Resource: "tekton.dev/v1alpha1, Resource=taskruns", GroupVersionKind: "tekton.dev/v1alpha1, Kind=TaskRun"
I1008 11:21:13.759] Name: "", Namespace: "default"
I1008 11:21:13.759] Object: &{map["apiVersion":"tekton.dev/v1alpha1" "kind":"TaskRun" "metadata":map["annotations":map["kubectl.kubernetes.io/last-applied-configuration":""] "generateName":"build-gcs-targz-" "namespace":"default"] "spec":map["inputs":map["resources":[map["name":"source" "resourceSpec":map["params":[map["name":"location" "value":"gs://build-crd-tests/archive.tar.gz"] map["name":"artifactType" "value":"TarGzArchive"] map["name":"type" "value":"build-gcs"]] "type":"storage"]]]] "taskSpec":map["inputs":map["resources":[map["name":"source" "type":"storage"]]] "steps":[map["command":["cat" "source/file.txt"] "image":"ubuntu"]]]]]}
I1008 11:21:13.760] from server for: "STDIN": resource name may not be empty
I1008 11:21:13.769] 2019/10/08 11:21:13 error executing 'kubectl apply': exit status 1
I1008 11:21:13.772] >> Waiting for tests to finish for taskrun
I1008 11:21:14.151] >> Checking test results for taskrun
I1008 11:21:14.599] >> All YAML tests passed

Steps to Reproduce the Problem

Additional Info

@afrittoli afrittoli added area/testing Issues or PRs related to testing priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Oct 9, 2019
@afrittoli afrittoli self-assigned this Oct 9, 2019
afrittoli added a commit to afrittoli/pipeline that referenced this issue Oct 9, 2019
When we create resources to run the YAML tests, we should fail tests
if the resource creation failed. Today this is ignored, which leads
to not running the tests at all!

Fixes tektoncd#1396
tekton-robot pushed a commit that referenced this issue Oct 15, 2019
When we create resources to run the YAML tests, we should fail tests
if the resource creation failed. Today this is ignored, which leads
to not running the tests at all!

Fixes #1396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant