Add pipeline strawman example #1

bobcatfish · 2018-09-01T00:17:55Z

@dlorenc @imjasonh @tejal29 @aaron-prindle and I have been working on a
strawman proposal for adding a Pipeline CRD and also for possibly
envolving the Build CRD into a slightly more generic Task CRD.

This PR demonstrates some paper prototype examples of what it could look
like to define pipelines using the CRDs described in the README.

Was originally at knative/build#319 - but this version actually has a PipelineRun and status fields for TaskRun!

pmorie · 2018-09-04T14:55:45Z

README.md

- A library of build pipelines
+# Pipeline CRD
+
+The goal of the Pipeline CRD is to provide k8s-style resources that allow the


One thing that I suspect people will wonder about when they read this doc that we might want to clarify is whether the Pipeline CRD is supposed to be an API+implementation, or an API that can be backed with an arbitrary implementation similar to Kubernetes ingress. The impression I was left with after the last working group meeting is that the goal was the former, not the latter. Is that correct? This phrase raised the question for me: "provide k8s-style resources".

I think I would classify this repo as "the API, and an on-cluster implementation of that API". Like ingress, or serving, or build, etc., one can imagine a CRD implementation that is backed by something off-cluster, or that just uses the API for compatibility and doesn't run "clusters" at all.

Yeah, that would be very helpful to explicitly state - it wasn't quite what I had taken away from prior convos

Thanks for pointing this out @pmorie! I'll add something right at the beginning to try to make this clear.

pmorie · 2018-09-04T14:56:56Z

README.md

+  [the Jenkins test analyzer plugin](https://wiki.jenkins.io/display/JENKINS/Test+Results+Analyzer+Plugin))
+* [Tasks](#tasks) can depend on artifacts, output and parameters created by other tasks.
+
+## TaskRun


Minor nit, does it make sense to introduce Task before TaskRun?

Yeah I think you're right - I had it the other way around before and then somehow got the crazy idea that this was clearer (I think b/c creating a TaskRun actually invokes the Task, kind of like creating a Build today will also run the steps in the Build) but I think you're right that introducing the Runs afterward makes more sense.

pmorie · 2018-09-04T15:15:12Z

examples/README.md

+This directory contains examples of [the Pipeline strawman CRDs](../README.md) in action.
+
+To deploy them to your cluster (after
+[installing the CRDs and running the controller](../DEVELOPMENT.md#installing-andrunning)):


Looks like this link would be broken?

thanks for catching this!

hm and that file is in fact missing XD - watch this space

bobcatfish · 2018-09-04T17:55:28Z

examples/invocations/run-kritis-test.yaml

+        - name: 'testBucket'
+          type: 'gcs'
+          url: 'gcs://somebucket/results/tests'
+status:


hmm after a bit more thought and looking at @aaron-prindle's proposals around templating, I'm thinking the status section should also include the buildSpec with templating applied

yes or a add a todo with a issue link describing templating proposal

EDIT: huh. Yes for the comment you had regarding @aaron-prindle proposal.
Github screwed this up.

tejal29

some nits.

tejal29 · 2018-09-05T21:27:26Z

examples/deploy_tasks.yaml

+            - name: clusterName
+    buildSpec:
+        steps:
+        # TODO: just guessing how helm works


remove this todo

lol but it's still true! XD

okay i'll remove it ;)

tejal29 · 2018-09-05T21:28:26Z

examples/invocations/kritis-pipeline-run.yaml

+        prevTasks:
+          - taskRef:
+            name: unit-test-kritis-12321312984
+  conditions:


Add a comment here, this will be auto filed by the controller?

ya the whole status section will be filled out by the controller - ill add a comment

tejal29 · 2018-09-05T21:29:07Z

examples/invocations/run-kritis-test.yaml

+        - name: 'testBucket'
+          type: 'gcs'
+          url: 'gcs://somebucket/results/tests'
+status:


yes or a add a todo with a issue link describing templating proposal

EDIT: huh. Yes for the comment you had regarding @aaron-prindle proposal.
Github screwed this up.

@dlorenc

@dlorenc @imjasonh @tejal29 @aaron-prindle and I have been working on a strawman proposal for adding a Pipeline CRD and also for possibly envolving the Build CRD into a slightly more generic Task CRD. This PR demonstrates some paper prototype examples of what it could look like to define pipelines using the CRDs described in the README.

nrshrivatsan · 2018-09-08T21:29:09Z

@bobcatfish - Could you please explain what's kriti and strawman?

bobcatfish · 2018-09-10T16:39:55Z

@bobcatfish - Could you please explain what's kriti and strawman?

Thanks for asking @nrshrivatsan !

Kritis is a project that some folks on the team (notably @tejal29 and @aaron-prindle ) have been working on: https://github.com/grafeas/kritis It's not actually relevant to the build-pipeline project and is only included here as an example since we were familiar with how to build + test it
strawman is a term for a proposal that is created for the purpose of generating discussion and debate - so not necessarily the proposal you want to use in the long run, but a starting point - see also https://en.wikipedia.org/wiki/Straw_man_proposal

I've also opened #25 to make this more clear in our docs.

Initial commit for OpenShift CI

Add pipeline strawman example

Initial commit for OpenShift CI

Add initial list of owners for event triggering ⚡

Add pod SPIFFE id annotation for workload registrar

Required fields and related webhook validations are added to support a user to configure the computing resources per Task/Pod which significantly reduces the over-asked amount configured by the step-level.

Required fields and related webhook validations are added to support a user to configure compute resources for TaskRun which will significantly reduce the over-asked resources amount configured by the Step-level.

bobcatfish mentioned this pull request Sep 1, 2018

Add pipeline strawman example knative/build#319

Closed

bobcatfish requested review from dlorenc, imjasonh and tejal29 September 1, 2018 01:00

pmorie reviewed Sep 4, 2018

View reviewed changes

bobcatfish commented Sep 4, 2018

View reviewed changes

bobcatfish force-pushed the pipeline_strawman branch from b1b3e12 to 70968b4 Compare September 5, 2018 21:23

bobcatfish requested a review from aaron-prindle September 5, 2018 21:23

tejal29 approved these changes Sep 5, 2018

View reviewed changes

bobcatfish force-pushed the pipeline_strawman branch from 70968b4 to 49d2316 Compare September 5, 2018 22:02

bobcatfish merged commit 3726a43 into master Sep 5, 2018

bobcatfish deleted the pipeline_strawman branch September 5, 2018 22:02

This was referenced Dec 8, 2018

Design Output handling #124

Closed

Reduce PipelineResource bindings #320

Closed

vdemeester referenced this pull request in vdemeester/tektoncd-pipeline Apr 3, 2019

Merge pull request #1 from mvinkler/mvinkler-master

a7dc623

Initial commit for OpenShift CI

chmouel pushed a commit to chmouel/tektoncd-pipeline that referenced this pull request Apr 11, 2019

Merge pull request tektoncd#1 from knative/pipeline_strawman

c868e16

Add pipeline strawman example

chmouel pushed a commit to chmouel/tektoncd-pipeline that referenced this pull request Apr 11, 2019

Merge pull request tektoncd#1 from mvinkler/mvinkler-master

e49e8d7

Initial commit for OpenShift CI

vdemeester mentioned this pull request Jun 6, 2019

Rename containerTemplate to stepTemplate 👠 #931

Merged

3 tasks

imjasonh mentioned this pull request Aug 16, 2019

Update build-gcs resource type to support .tar.gz archives #1200

Merged

jlewi mentioned this pull request Apr 9, 2020

kustomize package for tekton #1198

Closed

pradeepitm12 pushed a commit to pradeepitm12/pipeline that referenced this pull request Jan 28, 2021

Merge pull request tektoncd#1 from bobcatfish/owners

dbb8b53

Add initial list of owners for event triggering ⚡

pritidesai mentioned this pull request May 24, 2021

TEP-0061, Allow custom task to be embedded. #3901

Merged

5 tasks

wlynch mentioned this pull request Sep 24, 2021

Restrict step volumes as read-only #4227

Closed

3 tasks

lumjjb pushed a commit to lumjjb/pipeline that referenced this pull request Feb 8, 2022

Merge pull request tektoncd#1 from lumjjb/spire-lumjjb

3dd850a

Add pod SPIFFE id annotation for workload registrar

austinzhao-go mentioned this pull request May 9, 2022

TEP-0106: Support Specifying Metadata per Task in Runtime #4834

Merged

10 tasks

lbernick mentioned this pull request Jul 8, 2022

[FR] Pipeline-level sidecars #5112

Open

syan-tibco mentioned this pull request Apr 14, 2023

TaskRun timeout is always set to 1h0m0s after v0.40 #6520

Closed

ggallen mentioned this pull request May 17, 2023

Pipeline v1beta1 transformed to v1 #6674

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pipeline strawman example #1

Add pipeline strawman example #1

bobcatfish commented Sep 1, 2018

pmorie Sep 4, 2018

imjasonh Sep 4, 2018

pmorie Sep 5, 2018

bobcatfish Sep 5, 2018

pmorie Sep 4, 2018

bobcatfish Sep 5, 2018

pmorie Sep 4, 2018

bobcatfish Sep 5, 2018

bobcatfish Sep 5, 2018

bobcatfish Sep 4, 2018

tejal29 Sep 5, 2018 •

edited

Loading

tejal29 left a comment

tejal29 Sep 5, 2018

bobcatfish Sep 5, 2018

tejal29 Sep 5, 2018

bobcatfish Sep 5, 2018

tejal29 Sep 5, 2018 •

edited

Loading

nrshrivatsan commented Sep 8, 2018

bobcatfish commented Sep 10, 2018

Add pipeline strawman example #1

Add pipeline strawman example #1

Conversation

bobcatfish commented Sep 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tejal29 Sep 5, 2018 • edited Loading

Choose a reason for hiding this comment

tejal29 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tejal29 Sep 5, 2018 • edited Loading

Choose a reason for hiding this comment

nrshrivatsan commented Sep 8, 2018

bobcatfish commented Sep 10, 2018

tejal29 Sep 5, 2018 •

edited

Loading

tejal29 Sep 5, 2018 •

edited

Loading