Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-gcs resource type to support .tar.gz archives #1200

Merged
merged 1 commit into from
Aug 19, 2019

Commits on Aug 16, 2019

  1. Update build-gcs resource type

    - support both `ZipArchive` and `TarGzArchive` types now supported by `gcs-fetcher`
      - mark `Archive` type as deprecated ❌  (`ZipArchive` is the equivalent)
    - rename `gcs-resource-spec-taskrun.yaml` -> `build-gcs-{targz,zip}.yaml` to make their purposes clearer
      - make the taskrun name more descriptive
      - fetch a smaller file (`archive.{zip,tar.gz}`) containing a single file for faster tests ⏩
    - remove `test/gcs_taskrun_test.go` which didn't usefully test anything that wasn't tested in the YAML test
    - update docs to reflect these changes 📜
    - explicitly set `gcs-fetcher` image entrypoint
    
    And, while I'm at it:
    - remove support for `build-gcs` upload functionality
      - this doesn't appear to have worked and AFAIK nobody used it anyway
      - if we want to support it, we can, but probably not like that... it only supported `Manifest`-style uploads, for instance 🌵
      - remove `gcs-uploader` image from flags, and from `vendor/` and from `tekton/` release pipeline YAMLs 🎉
    imjasonh committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    ae7d5c3 View commit details
    Browse the repository at this point in the history