Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct pod watching in Taskrun controller #1269

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

vincent-pli
Copy link
Member

Should use cache.FilteringResourceEventHandler rather than cache.ResourceEventHandlerFuncs.
The pod with incorrect owner will not go into the queue.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Should use `cache.FilteringResourceEventHandler` rather than `cache.ResourceEventHandlerFuncs`.
The `pod` with incorrect owner will not go into the queue.
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Sep 4, 2019
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 4, 2019
@vincent-pli
Copy link
Member Author

/assign @imjasonh

Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this.
I started reading about informers but I think I need a bit more background to fully understand this.
One thing I noticed looking at controller logs is that I often get errors about resources that aren't supposed to be in the taskrun controller queue to begin with, so perhaps this is about fixing that?

Example:

{"level":"info","logger":"controller.taskrun-controller","caller":"taskrun/taskrun.go:94","msg":"task run \"istio-system/istio-telemetry-78f76f9d6\" in work queue no longer exists","knative.dev/controller":"taskrun-controller"}

@vincent-pli
Copy link
Member Author

@afrittoli
Exactly, the issue will be fix by this PR.

Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, vincent-pli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2019
@tekton-robot tekton-robot merged commit 04dfa5b into tektoncd:master Sep 23, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants