Move nopImage and entrypointImage from pkg/… package to cmd/controller #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
approved
vdemeester
changed the title
|
/lgtm |
|
/hold |
tekton-robot
added
the
do-not-merge/hold
imjasonh
reviewed
Sep 24, 2019
cmd/controller/main.go
Outdated
| func main() { | ||
| images := map[string]string{ |
There was a problem hiding this comment.
Maybe an Images struct with named fields? Having a map makes it seem like people should be able to add any image they want, and invites typos.
There was a problem hiding this comment.
indeed, I would prefer that 😝
vdemeester
force-pushed
the
no-more-global-flags
branch
from
251d360
to
0dd0e03
Compare
|
Updated 👼 |
|
/lgtm |
|
/test pull-tekton-pipeline-integration-tests |
This is part of a set of changes to make sure we don't define CLI flags in our `pkg/…` packages… so that importing packages from there do not pollute the cli flags. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
no-more-global-flags
branch
from
0dd0e03
to
3b3c7e5
Compare
This is part of a set of changes to make sure we don't define CLI flags in our `pkg/…` packages… so that importing packages from there do not pollute the cli flags. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
no-more-global-flags
branch
from
3b3c7e5
to
7a85628
Compare
|
/lgtm |
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
3 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is part of a set of changes to make sure we don't define CLI
flags in our
pkg/…packages… so that importing packages from theredo not pollute the cli flags.
This is part of #1309 — submitting this one alone to gather early feedback and make sure this is the way to go (aka I am not a fan of the map in this change so far)
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.