Inline the ResourceDeclaration struct in TaskResource

[nlewo]

Before the commit 92d5bcc, attributes
of ResourceDeclaration belong to TaskResource.

This avoids generated JSON structures to contain the useless
ResourceDeclaration attribute.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[tekton-robot]

Hi @nlewo. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nlewo]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[vdemeester]

/ok-to-test
/cc @dibyom @bobcatfish

[dibyom]

/lgtm

[vdemeester]

/lgtm
/hold
/cc @bobcatfish

I don't think it has any backward incompatible effect but… I want a 2nd set of eyes on this 👼

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlewo, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bobcatfish]

@nlewo sounds like this is a good change but I'm not super familiar with what "inline" does - im also a bit confused b/c I thought if it changed the way the json fields are treated, that some of our generated code would change but it looks like it doesn't.

This avoids generated JSON structures to contain the useless ResourceDeclaration attribute.

Could you explain a bit more about what the generated structures look like before and after this change? Also interested in more detail about how you ran into this (i.e. if it causes problems for users)

[nlewo]

@bobcatfish I ran into this issue because I tried to generate cue files from your go sources: the objective is to extract a schema as the cue kubernetes tutorial does.
Without the inline tag, cue generates this struct (a piece of the struct):

spec:
  inputs:
    resources:
    - ResourceDeclaration:
        name: "source"
        type: "git"

while with the inline tag it generates:

spec:
  inputs:
    resources:
    -  name: "source"
        type: "git"

This is also explained in the cue get go --help message:

	- embedded structs marked with a json inline tag unify with struct
	  definition. For instance, the Go struct

	    struct MyStruct {
			Common  json:",inline"
			Field string
		 }

	  translates to the CUE struct

		 MyStruct: Common & {
			 Field: string
		 }

The Go json marshaller, by default, inlines embedded structs (i didn't try before you asked for).I tried to find some documentation about this tag, but I wasn't able to:/ That's really strange!
Note that you are already using such kind of tag here for instance.

[nlewo]

So, this inline flag is recognized by the go-yaml package (go-yaml/yaml@8691640) but I have not been able to find it in the go-json package!

[dibyom]

Thanks for the thorough explanation @nlewo !
/hold cancel