Support multiple SSH keys for the same host #1433
Conversation
googlebot
added
the
cla: yes
tekton-robot
added
the
size/M
|
The following is the coverage report on pkg/.
|
|
/lgtm |
| @@ -305,8 +307,8 @@ func TestSSHFlagHandlingThrice(t *testing.T) { | |||
| HostName github.com | |||
| IdentityFile %s | |||
| Port 22 | |||
| Host gitlab.com | |||
| HostName gitlab.com | |||
| Host github.com | |||
There was a problem hiding this comment.
Does having multiple exact same Host works ? I read a bit man ssh_config and I am not sure it's documented (either works or not), but I have a fear it doesn't as it's gonna pick up the first one and if it fails, it will considered it failed.
I think it's possible to pass multiple IdentityFile though, like
Host github.com
IdentityFile /etc/ssh/my_project_1_github_deploy_key
IdentityFile /etc/ssh/my_project_2_github_deploy_key
There was a problem hiding this comment.
I think you're right. Reading https://superuser.com/q/366649 it looks like the correct way to handle this is with multiple differently-named Hosts which each specify the same HostName
I've updated the PR to do this, where each Host includes the secret name to dedupe.
There was a problem hiding this comment.
Seems I was wrong! Thanks e2e tests! :)
imjasonh
force-pushed
the
ssh-multiple
branch
from
b4838fc
to
fcd4d41
Compare
tekton-robot
added
size/L
|
The following is the coverage report on pkg/.
|
imjasonh
force-pushed
the
ssh-multiple
branch
from
fcd4d41
to
b853cc6
Compare
|
The following is the coverage report on pkg/.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Before this change, if users provided two secrets annotated to target the same host,
creds-initwould fail to generate the ssh config.This use case is entirely valid, to allow users to rotate keys for instance.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes