Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add values for types in resources #54

Merged
merged 1 commit into from
Sep 18, 2018

Commits on Sep 17, 2018

  1. Add values for types in resources

    Added values for the following types, which would be the initial types
    we would want to implement and support (could expand to support more in
    the future):
    - `SourceType`
    - `ArtifactType`
    - `ResultTargetType`
    - `PipelineTriggerType` and `TaskTriggerType`
    - `ParamType` (just strings for now?)
    
    Since in #39 @pivotal-nader-ziada and @shashwathi are combining Sources
    and Artifacts into one concept, we'll likely combine `SourceType` and
    `ArtifactType` into one type as well.
    
    While doing this noticed and cleaned up a couple things:
    - Don't need to specify lists of result stores, just one
      for each type (test, log, runs). Also these are identical
      except for their usage, so we can use a common type for all of them
    - Turns out pipeline run specs were not defined!
    - Updated DEVELOPMENT.md re. how to regenerate generated code
      (such as `zz_generated.deepcopy.go`)
    
    Fixes #18
    bobcatfish committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    16912c0 View commit details
    Browse the repository at this point in the history