Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.39.x] Improve DAG validation for pipelines with hundreds of tasks #5432

Merged
merged 1 commit into from
Sep 7, 2022
Merged

[release-v0.39.x] Improve DAG validation for pipelines with hundreds of tasks #5432

merged 1 commit into from
Sep 7, 2022

Conversation

tekton-robot
Copy link
Collaborator

This is an automated cherry-pick of #5421

/assign afrittoli

bug fixes:
- https://github.com/tektoncd/pipeline/issues/5420 - Improve DAG validation for pipelines with hundreds of tasks (validation wehbook performance)

@rafalbigaj
Improve DAG validation for pipelines with hundreds of tasks
21478ff 
DAG validation rewritten using Kahn's algorithm to find cycles in task dependencies.

Original implementation, as pointed at tektoncd#5420 is a root cause of poor validation webhook performance, which fails on default timeout (10s).
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 6, 2022
@tekton-robot tekton-robot mentioned this pull request Sep 6, 2022
Merged
5 tasks
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 6, 2022
@abayer
Copy link
Contributor

abayer commented Sep 6, 2022 •
edited
Loading

This needs a1ca389

@abayer abayer mentioned this pull request Sep 6, 2022
Merged
7 tasks
@abayer
Copy link
Contributor

abayer commented Sep 6, 2022

/kind bug
/retest

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 6, 2022
@abayer
Copy link
Contributor

abayer commented Sep 6, 2022

/approve

@tekton-robot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2022
@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2022
@abayer
Copy link
Contributor

abayer commented Sep 7, 2022

/test check-github-tasks-completed

@tekton-robot
Copy link
Collaborator Author

@abayer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-github-tasks-completed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abayer
Copy link
Contributor

abayer commented Sep 7, 2022

/retest

@tekton-robot tekton-robot merged commit 3171a67 into tektoncd:release-v0.39.x Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai Awaiting requested review from pritidesai

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vdemeester vdemeester

@afrittoli afrittoli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tekton-robot @abayer @vdemeester @afrittoli @rafalbigaj