Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0142: Introduce feature flag enable-step-actions #7277

Merged
merged 1 commit into from
Oct 25, 2023
Merged

TEP-0142: Introduce feature flag enable-step-actions #7277

merged 1 commit into from
Oct 25, 2023

Conversation

chitrangpatel
Copy link
Member

@chitrangpatel chitrangpatel commented Oct 25, 2023 •
edited
Loading

This PR introduces the feature flag enable-step-actions. The follow up PRs will use this feature flag to gate the use of StepActions in Tasks.

This is the second item on the implementation Issue #7259

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

[WIP] Introduces a new feature flag "enable-step-actions: true/false" to gate the use of step actions.

/kind feature

@chitrangpatel
Introduce feature flag enable-step-actions
427e88b 
This PR introduces the feature flag `enable-step-actions`.
The follow up PRs will use this feature flag to gate the validation
logic.
@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2023
This was referenced Oct 25, 2023
Closed
Merged
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.0% 94.1% 0.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.0% 94.1% 0.1

@JeromeJu
Copy link
Member

/assign

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
jerop
jerop approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for breaking it down @chitrangpatel

@tektoncd/core-maintainers please take a look

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeromeJu, jerop, Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Yongxuanzhang,jerop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jerop
jerop reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@tekton-robot tekton-robot merged commit 08ee164 into tektoncd:main Oct 25, 2023
12 checks passed
@JeromeJu JeromeJu mentioned this pull request Oct 25, 2023
Merged
7 tasks
@jerop jerop changed the title Introduce feature flag enable-step-actions TEP-0142: Introduce feature flag enable-step-actions Oct 25, 2023
@JeromeJu JeromeJu mentioned this pull request Oct 25, 2023
Closed
@jerop jerop added this to the Pipelines v0.54 milestone Oct 26, 2023
This was referenced Feb 22, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@Yongxuanzhang Yongxuanzhang Yongxuanzhang approved these changes

@JeromeJu JeromeJu JeromeJu approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@jerop jerop

@JeromeJu JeromeJu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.54
Development

Successfully merging this pull request may close these issues.
5 participants
@chitrangpatel @tekton-robot @JeromeJu @jerop @Yongxuanzhang