Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove conversion configuration for ClusterTask #7796

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Remove conversion configuration for ClusterTask #7796

merged 1 commit into from
Mar 25, 2024

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Mar 25, 2024 •
edited
Loading

Changes

ClusterTask only exists in v1beta1 and will never have a v1 thus
doesn't need to be registered in the conversion webhook.

Prior to this commit, some tooling (like
https://github.com/openshift/cluster-kube-apiserver-operator/) might
assume there is a conversion webhook and then fail to communicate with
it (because we do not register ClusterTask in the conversion webhook
part) ; generating a lot of spam log.

As a rules of thumb, if we are not registering/refering an object in
newConversionController (in cmd/webhook/main.go), the conversion
field in the CRD shouldn't be defined either.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Remove conversion webhook configuration from the ClusterTask CRD, it doesn't need it.

@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 25, 2024
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 25, 2024
@vdemeester
Remove conversion configuration for ClusterTask
358c142 
`ClusterTask` only exists in `v1beta1` and will never have a `v1` thus
doesn't need to be registered in the conversion webhook.

Prior to this commit, some tooling (like
https://github.com/openshift/cluster-kube-apiserver-operator/) might
assume there is a conversion webhook and then fail to communicate with
it (because we do not register `ClusterTask` in the conversion webhook
part) ; generating a lot of spam log.

As a rules of thumb, if we are not registering/refering an object in
`newConversionController` (in `cmd/webhook/main.go`), the `conversion`
field in the CRD shouldn't be defined either.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester
Copy link
Member Author

/cherry-pick release-v0.56.x

@tekton-robot
Copy link
Collaborator

@vdemeester: once the present PR merges, I will cherry-pick it on top of release-v0.56.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.56.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member Author

/cherry-pick release-v0.53.x

@tekton-robot
Copy link
Collaborator

@vdemeester: once the present PR merges, I will cherry-pick it on top of release-v0.53.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.53.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member Author

/cherry-pick release-v0.50.x

@tekton-robot
Copy link
Collaborator

@vdemeester: once the present PR merges, I will cherry-pick it on top of release-v0.50.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.50.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member Author

/cherry-pick release-v0.47.x

@tekton-robot
Copy link
Collaborator

@vdemeester: once the present PR merges, I will cherry-pick it on top of release-v0.47.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.47.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member Author

Related to #7794

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
dibyom
dibyom reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@tekton-robot tekton-robot merged commit 35a3dab into tektoncd:main Mar 25, 2024
11 checks passed
@tekton-robot
Copy link
Collaborator

@vdemeester: new pull request created: #7797

In response to this:

/cherry-pick release-v0.53.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 25, 2024
Merged
Merged
@tekton-robot
Copy link
Collaborator

@vdemeester: new pull request created: #7798

In response to this:

/cherry-pick release-v0.50.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

@vdemeester: new pull request created: #7799

In response to this:

/cherry-pick release-v0.47.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Mar 25, 2024
Merged
@tekton-robot
Copy link
Collaborator

@vdemeester: new pull request created: #7800

In response to this:

/cherry-pick release-v0.56.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Mar 25, 2024
Merged
@vdemeester vdemeester deleted the 7794-clustertask branch March 25, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@chitrangpatel chitrangpatel chitrangpatel approved these changes

@abayer abayer Awaiting requested review from abayer

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vdemeester @tekton-robot @dibyom @chitrangpatel