Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.59.x] fix: resolve issue where results may not be obtained from sidecar logs #8097

Merged
merged 1 commit into from
Jul 4, 2024
Merged

[release-v0.59.x] fix: resolve issue where results may not be obtained from sidecar logs #8097

merged 1 commit into from
Jul 4, 2024

Conversation

tekton-robot
Copy link
Collaborator

This is an automated cherry-pick of #8029

/assign pritidesai

fix: resolve issue where results may not be obtained from sidecar logs

@l-qing
fix: resolve issue where results may not be obtained from sidecar logs
f8ad91c 
fix: tektoncd#8028

If the sidecar is not completed, the complete log may not be retrieved from it,
thus unable to parse the final task results.
@tekton-robot tekton-robot mentioned this pull request Jul 4, 2024
Merged
8 tasks
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2024
@pritidesai
Copy link
Member

Please take a look @tektoncd/core-maintainers, thanks!

@pritidesai
Copy link
Member

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 4, 2024
@chitrangpatel
Copy link
Member

/approve

@tekton-robot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@tekton-robot
Copy link
Collaborator Author

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/status.go 93.8% 94.8% 1.0

@tekton-robot
Copy link
Collaborator Author

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/status.go 93.8% 94.8% 1.0

@pritidesai
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
@tekton-robot tekton-robot merged commit 84aa130 into tektoncd:release-v0.59.x Jul 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli Awaiting requested review from afrittoli

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@pritidesai pritidesai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tekton-robot @pritidesai @chitrangpatel @l-qing