Add isBuildArtifact field to Artifacts

[chitrangpatel]

Changes

As justified in TEP tektoncd/community#1155, this PR adds isBuildArtifact field to Artifacts.
This field will allow Tekton Chains to understand user's desire and appropriate add the artifact as a subject or a byProduct in the SLSA provenance.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Add `isBuildArtifact` field to Artifacts.

/kind feature

[chitrangpatel]

/assign @ericzzzzzzz

[tekton-robot]

@chitrangpatel: GitHub didn't allow me to assign the following users: ericzzzzzzz.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @ericzzzzzzz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ericzzzzzzz]

We may need to refactor

pipeline/pkg/apis/pipeline/v1/artifact_types.go

Line 52 in 92f43ee

func (a *Artifacts) Merge(another Artifacts) {

to merge IsBuildArtifact from stepArtifact into taskArtifact, without this, IsBuildArtifact will not be propagated to status.Artifacts.outputs if we write artifacts to $(step.artifacts.path)

[chitrangpatel]

We may need to refactor

pipeline/pkg/apis/pipeline/v1/artifact_types.go

Line 52 in 92f43ee

func (a *Artifacts) Merge(another Artifacts) {

to merge IsBuildArtifact from stepArtifact into taskArtifact, without this, IsBuildArtifact will not be propagated to status.Artifacts.outputs if we write artifacts to $(step.artifacts.path)

Thanks! I think I fixed it. When merging, even if one of the artifacts has isBuildArtifact: true then we merge them with the true state since it is more conservative.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/artifact_types.go	94.7%	95.5%	0.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/artifact_types.go	94.7%	95.5%	0.7

[chitrangpatel]

/hold wait for tektoncd/community#1155

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/artifact_types.go	94.7%	95.5%	0.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/artifact_types.go	94.7%	95.5%	0.7

[ericzzzzzzz]

/approve

[chitrangpatel]

/hold cancel

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/artifact_types.go	94.7%	95.5%	0.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/artifact_types.go	94.7%	95.5%	0.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/artifact_types.go	94.7%	95.5%	0.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/artifact_types.go	94.7%	95.5%	0.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/artifact_types.go	94.7%	95.5%	0.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/artifact_types.go	94.7%	95.5%	0.7

[chitrangpatel]

/retest

[chitrangpatel]

/retest

[wlynch]

/lgtm

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/artifact_types.go	94.7%	95.5%	0.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/artifact_types.go	94.7%	95.5%	0.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/artifact_types.go	94.7%	95.5%	0.7

[JeromeJu]

Checking my understanding - this field should have the same stability level as Artifacts as an alpha feature correct?

btw I don't seem to find artifacts in the alpha feature table https://github.com/tektoncd/pipeline/blob/main/docs/additional-configs.md#alpha-features?

[chitrangpatel]

Checking my understanding - this field should have the same stability level as Artifacts as an alpha feature correct?

Yes, that's right. It should be the same stability level.

btw I don't seem to find artifacts in the alpha feature table https://github.com/tektoncd/pipeline/blob/main/docs/additional-configs.md#alpha-features?

I can add that in a separate PR.

[JeromeJu]

Mostly LGTM, just some minor feature versioning issue mentioned which could be in separate PRs.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ericzzzzzzz, JeromeJu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JeromeJu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chitrangpatel]

/retest