DryRunValidate returns the mutated object #8108
Conversation
tekton-robot
added
release-note
tekton-robot
added
the
size/L
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
return-mutated-object
branch
from
83c4286
to
7e72c94
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
return-mutated-object
branch
from
7e72c94
to
94e9b55
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
| // Issue a dry-run request to create the remote Pipeline, so that it can undergo validation from validating admission webhooks | ||
| // without actually creating the Pipeline on the cluster. | ||
| if err := apiserver.DryRunValidate(ctx, namespace, obj, tekton); err != nil { | ||
| // Issue a dry-run request to create the remote Task, so that it can undergo validation from validating admission webhooks |
There was a problem hiding this comment.
NIT: was the original comment valid?
Issue a dry-run request to create the remote Pipeline
There was a problem hiding this comment.
Yes. copy-paste error 😅 Fixing.
It would be great to maintain the code coverage. |
chitrangpatel
force-pushed
the
return-mutated-object
branch
2 times, most recently
from
8382ac9
to
3e38d31
Compare
|
thanks @chitrangpatel |
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
return-mutated-object
branch
from
3e38d31
to
deea321
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
/retest |
1 similar comment
|
/retest |
|
the integration tests are failing because we hit the Docker pull rate limit: |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
Prior to this, when validating remotely resolved resources, we performed a dry run. When a dry run is performed, the resource is passed through the mutating webhook admission controllers followed by the validating webhook controllers. We only validated the object and inserted the spec of the original object instead of the mutated object. This means that if users have mutating webhook controllers on their cluster then remotely resolved resources are not mutated when passed to the taskrun/pipelinerun. This PR fixes that. Fixes tektoncd#8071
chitrangpatel
force-pushed
the
return-mutated-object
branch
from
deea321
to
2329d1a
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
/retest |
|
/lgtm |
|
/retest |
Prior to this, when validating remotely resolved resources, we performed a dry run. When a dry run is performed, the resource is passed through the mutating webhook admission controllers followed by the validating webhook controllers. We only validated the object and inserted the spec of the original object instead of the mutated object. This means that if users have mutating webhook controllers on their cluster then remotely resolved resources are not mutated when passed to the taskrun/pipelinerun. This PR fixes that.
Fixes #8071
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind bug