Skip to content

Commit

Permalink
Update pull_request_template.md
Browse files Browse the repository at this point in the history
Updates our pull_request_template to match that of pipeline's. Adds some additional checks for adding kind label etc.
  • Loading branch information
dibyom authored and tekton-robot committed May 10, 2023
1 parent 8cf5614 commit b185d03
Showing 1 changed file with 11 additions and 36 deletions.
47 changes: 11 additions & 36 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,48 +1,23 @@
# Changes

<!-- πŸŽ‰πŸŽ‰πŸŽ‰ Thank you for the PR!!! πŸŽ‰πŸŽ‰πŸŽ‰ -->

<!-- Describe your changes here- ideally you can get that description straight from
your descriptive commit message(s)! -->
# Changes

# Submitter Checklist
<!-- Describe your changes here- ideally you can get that description straight from your descriptive commit message(s)! -->

These are the criteria that every PR should meet, please check them off as you
review them:
# Submitter Checklist

- [ ] Includes [tests](https://github.com/tektoncd/community/blob/master/standards.md#tests) (if functionality changed/added)
- [ ] Includes [docs](https://github.com/tektoncd/community/blob/master/standards.md#docs) (if user facing)
- [ ] Commit messages follow [commit message best practices](https://github.com/tektoncd/community/blob/master/standards.md#commits)
- [ ] Release notes block has been filled in or deleted (only if no user facing changes)
As the author of this PR, please check off the items in this checklist:

_See [the contribution guide](https://github.com/tektoncd/triggers/blob/master/CONTRIBUTING.md) for more details._
- [ ] Has [Docs](https://github.com/tektoncd/community/blob/main/standards.md#docs) if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
- [ ] Has [Tests](https://github.com/tektoncd/community/blob/main/standards.md#tests) included if any functionality added or changed
- [ ] Follows the [commit message standard](https://github.com/tektoncd/community/blob/main/standards.md#commits)
- [ ] Meets the [Tekton contributor standards](https://github.com/tektoncd/community/blob/main/standards.md) (including functionality, content, code)
- [ ] Has a kind label. You can add one by adding a comment on this PR that contains `/kind <type>`. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
- [ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of [good release notes](https://github.com/tektoncd/community/blob/main/standards.md#good-release-notes).
- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

# Release Notes

<!--
Describe any user facing changes here, or delete this block.
Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior
- Changes requiring upgrade notices or deprecation warnings
For pull requests with a release note:
```release-note
Your release note here
```
For pull requests that require additional action from users switching to the new release, include the string "action required" (case insensitive) in the release note:
```release-note
action required: your release note here
```
For pull requests that don't need to be mentioned at release time, use the `/release-note-none` Prow command to add the `release-note-none` label to the PR. You can also write the string "NONE" as a release note in your PR description:
```release-note
NONE
```
-->

0 comments on commit b185d03

Please sign in to comment.