Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trigger eventID to be used as input to TriggerBinding #1449

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

jmcshane
Copy link
Contributor

@jmcshane jmcshane commented Sep 27, 2022

Resolves #1427

Changes

Propagate eventID into the TriggerBinding evaluation to allow this value to be used in bindings. Adds TriggerContext object to template package to allow future additions to this data if other inputs are desired.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Add eventID as input to TriggerBinding

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 27, 2022
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! And welcome back!!
Can we document $(context.eventID) in the trigger template docs?

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2022
@jmcshane
Copy link
Contributor Author

@dibyom thanks! im planning to join the triggers wg tomorrow as well. long life story over the last 18 months or so, but I hope to make helpful contributions once again

ill update the docs

Resolves tektoncd#1427

Adds TriggerContext object to template package to allow future additions to this data if other inputs are desired.
@jmcshane
Copy link
Contributor Author

@dibyom docs updated

@dibyom
Copy link
Member

dibyom commented Sep 27, 2022

@dibyom thanks! im planning to join the triggers wg tomorrow as well. long life story over the last 18 months or so, but I hope to make helpful contributions once again

looking forward!

And thanks for the quick update!

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2022
@tekton-robot tekton-robot merged commit c147f7d into tektoncd:main Sep 27, 2022
@dibyom dibyom added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EventID in parameter variable substitution
3 participants