Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenSSF Best Practices Badge #1458

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Add OpenSSF Best Practices Badge #1458

merged 1 commit into from
Oct 12, 2022

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Oct 4, 2022

Changes

cc @afrittoli

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 4, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 4, 2022
@dibyom
Copy link
Member Author

dibyom commented Oct 10, 2022

/assign @khrm @savitaashture

@afrittoli afrittoli closed this Oct 11, 2022
@afrittoli afrittoli reopened this Oct 11, 2022
@afrittoli
Copy link
Member

/lgtm

Not sure why tide is not happy

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2022
savitaashture
savitaashture approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2022
@tekton-robot tekton-robot merged commit 96a078b into main Oct 12, 2022
@dibyom dibyom deleted the dibyom-patch-1 branch October 12, 2022 14:30
@dibyom dibyom added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture approved these changes

@ncskier ncskier Awaiting requested review from ncskier

@vtereso vtereso Awaiting requested review from vtereso

Assignees

@khrm khrm

@afrittoli afrittoli

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dibyom @afrittoli @tekton-robot @savitaashture @khrm