Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error by given linters during tests #1578

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Apr 19, 2023

Fix error given by revive linter either by commenting if it can't be fixed or fixing the issue.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 19, 2023
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 19, 2023
@khrm khrm changed the title Fix Error by revive linter Fix Error by given linters during tests Apr 19, 2023
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Apr 19, 2023
@khrm
Copy link
Contributor Author

khrm commented Apr 19, 2023

/release-note-none

@tekton-robot
Copy link

@khrm: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 19, 2023
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/server/server.go 78.9% 79.7% 0.8

@khrm
Copy link
Contributor Author

khrm commented Apr 19, 2023

/test tekton-triggers-unit-tests

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/server/server.go 78.9% 79.7% 0.8

Fix error given by revive linter either by commenting if it can't
be fixed or by fixing the issue.
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/server/server.go 78.9% 79.7% 0.8

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/server/server.go 78.9% 79.7% 0.8
pkg/reconciler/eventlistener/resources/custom.go 93.8% 93.8% -0.1

@khrm
Copy link
Contributor Author

khrm commented Apr 19, 2023

@dibyom Please merge this to resolve the latest CI issue with the build test failure.

Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2023
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2023
@tekton-robot tekton-robot merged commit 2713832 into tektoncd:main Apr 19, 2023
@khrm
Copy link
Contributor Author

khrm commented Apr 19, 2023

/cherry-pick release-v0.22.x

@khrm khrm deleted the m/revive branch April 19, 2023 22:20
@tekton-robot
Copy link

@khrm: #1578 failed to apply on top of branch "release-v0.22.x":

Applying: Fix Error by revive linter for build tests
Using index info to reconstruct a base tree...
M	pkg/apis/triggers/v1beta1/event_listener_validation.go
M	pkg/apis/triggers/v1beta1/trigger_binding_validation.go
M	pkg/apis/triggers/v1beta1/trigger_template_validation.go
M	pkg/apis/triggers/v1beta1/trigger_validation.go
M	pkg/interceptors/server/server_test.go
M	pkg/sink/sink_test.go
M	test/eventlistener_test.go
M	test/wait.go
Falling back to patching base and 3-way merge...
Auto-merging test/wait.go
Auto-merging test/eventlistener_test.go
Auto-merging pkg/sink/sink_test.go
Auto-merging pkg/interceptors/server/server_test.go
Auto-merging pkg/apis/triggers/v1beta1/trigger_validation.go
Auto-merging pkg/apis/triggers/v1beta1/trigger_template_validation.go
Auto-merging pkg/apis/triggers/v1beta1/trigger_binding_validation.go
Auto-merging pkg/apis/triggers/v1beta1/event_listener_validation.go
CONFLICT (content): Merge conflict in pkg/apis/triggers/v1beta1/event_listener_validation.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix Error by revive linter for build tests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v0.22.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants